[RFC PATCH 07/19] table: fix issues with variable shadowing

Stephen Hemminger stephen at networkplumber.org
Thu Nov 6 20:37:16 CET 2025


On Thu,  6 Nov 2025 14:09:36 +0000
Bruce Richardson <bruce.richardson at intel.com> wrote:

> diff --git a/lib/table/rte_lru.h b/lib/table/rte_lru.h
> index 28aab12923..1436425e16 100644
> --- a/lib/table/rte_lru.h
> +++ b/lib/table/rte_lru.h
> @@ -41,33 +41,33 @@ while (0)
> 
>  #define lru_update(bucket, mru_val)					\
>  do {									\
> -	uint64_t x, pos, x0, x1, x2, mask;				\

Why is this a macro? Prefer inline functions where there is checking on types etc.


More information about the dev mailing list