[PATCH v11 0/9] lib/pmu: cleanups and trace integration
Tomasz Duszynski
tduszyns at gmail.com
Fri Nov 7 15:33:35 CET 2025
On Wed, Nov 05, 2025 at 02:38:44PM +0100, David Marchand wrote:
> Strange output in the cover letter.
I think I let vimdiff copy to much from previous cover letter.
>
> Shortlog shows 10 patches:
> > Tomasz Duszynski (10):
>
> Followed by 8 lines:
> > trace: change scope of conditional block
> > lib/pmu: export only necessary arch headers
> > lib/pmu: reimplement per-arch ops as callbacks
> > lib/pmu: do not try enabling perf counter access on arm64
> > lib/pmu: use build system defined RTE_LIB_PMU macro
> > test/pmu: enable test
> > trace: add PMU
> > lib/pmu: fix out-of-bound access
>
> But the series has 9 patches.
>
> In any case,
> - patch 2 "trace: change scope of conditional block" is unneeded, I
> see nothing wrong with current code. I tried stopping at various
> points of the series, no build issue,
I'll take another look because I cannot recall at this point all
specifics of this change. Most likely thing was some CI build issue.
> - patch 7 has a comment from Morten,
> - patch 8 has comments from me,
Ack.
> - patch 9 is vague, what is this about? Fixing coverity or some static
> analysis tool bug report?
Most likely that was from some coverity report. I don't have access to
corporate mbox so I'm not able to track this down at this point.
Regardless of that, this fix is about making string NUL terminated.
Otherwise strtol() may go haywire.
>
> I applied the rest of the series, as other patches look valid fixes / cleanups.
>
Thanks!
>
> --
> David Marchand
>
More information about the dev
mailing list