[PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close

[David Marchand]

On Fri, 7 Nov 2025 at 09:32, David Marchand <david.marchand at redhat.com> wrote:
> > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> > index 7da32ce856..f3db7982a4 100644
> > --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> > @@ -3347,14 +3347,17 @@ static int
> >  rte_dpaa2_remove(struct rte_dpaa2_device *dpaa2_dev)
> >  {
> >         struct rte_eth_dev *eth_dev;
> > -       int ret;
> > +       int ret = 0;
> >
> >         eth_dev = dpaa2_dev->eth_dev;
>
> Having a back reference of the "class" object in a "device" object
> seems wrong to me (and there is a dev_priv->eth_dev too...).
> It breaks the separation that was introduced with rte_device years ago.

I went and had a try:
https://patchwork.dpdk.org/project/dpdk/list/?series=36627

No promise it works, but it is cleaner this way.


-- 
David Marchand