[PATCH v5 48/57] net/bnxt: add meson build options for TruFlow

[Thomas Monjalon]

29/10/2025 17:07, Manish Kurup:
> Add meson options for
> 1. TF template
> 2. TF feature bits
> 
> Signed-off-by: Manish Kurup <manish.kurup at broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> ---
> +option('bnxt_tf_template', type: 'string', value: 'default', description:
> +       'Truflow template selection')
> +option('bnxt_tf_feat_bits', type: 'integer', value: 0, description:
> +       'Truflow feature bits')

Ouch, I missed that. This file was not part of my regular checks.
It is clearly not the direction taken for DPDK compilation these last years.
We tend to simplify the compilation matrix.

Anyway bnxt_tf_feat_bits is not used in the driver compilation.

I copy here an abstract of the use of the other option in another patch:
"
if get_option('bnxt_tf_template').contains('app19')
includes += include_directories('app_19_templates')
subdir('app_19_templates')
cflags += '-DBNXT_TF_APP_ID=19'
"

It is not documented, and the subdirectory is missing.

This whole thing looks very strange, so this patch is obiously rejected.