[PATCH v2] app/testpmd: warn on shared rxq switch mismatch

Stephen Hemminger stephen at networkplumber.org
Wed Nov 26 16:02:17 CET 2025


On Wed, 26 Nov 2025 11:40:09 +0100
a.schollmeyer at syseleven.de wrote:

> +				if (mismatch) {
> +					fprintf(stderr, "Bad shared rxq config: "
> +						"%s mismatch in share group/qid %u/%u: "

It is better to not split formats across lines.
Can you shorten it, and put on oneline.
Despite what checkpatch may say, you can make that a longish line like 200 characters.
Also, maybe break from the loop on first mismatch? and return an error?
Then message can be outside the loop.


More information about the dev mailing list