[PATCH v10 1/3] net/macb: add new poll mode driver

[Stephen Hemminger]

On Wed, 20 Aug 2025 04:33:09 +0000
Wencheng Li <liwencheng at phytium.com.cn> wrote:

> +int __rte_cold macb_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
> +							uint16_t nb_desc, unsigned int socket_id,
> +							const struct rte_eth_rxconf *rx_conf,
> +							struct rte_mempool *mp)
> +{

Please take off __rte_cold except where necessary; in later followups.

It is meant for special cases (like rte_log) where code that calls that
function should be less favored and does not need speed optimization.
In a driver like this it just is clutter.