[PATCH v1 9/9] net/nbl: address channel Incorrect expression issues 490958

[Stephen Hemminger]

On Mon, 27 Oct 2025 03:16:48 -0700
Dimon Zhao <dimon.zhao at nebula-matrix.com> wrote:

> Coverity issue: 490958
> 
> Signed-off-by: Dimon Zhao <dimon.zhao at nebula-matrix.com>
> ---
>  drivers/net/nbl/nbl_hw/nbl_channel.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/nbl/nbl_hw/nbl_channel.c b/drivers/net/nbl/nbl_hw/nbl_channel.c
> index 654e56f200..acbceecc46 100644
> --- a/drivers/net/nbl/nbl_hw/nbl_channel.c
> +++ b/drivers/net/nbl/nbl_hw/nbl_channel.c
> @@ -856,9 +856,12 @@ static void nbl_chan_remove_state_bitmap(void *priv)
>  {
>  	struct nbl_channel_mgt *chan_mgt = (struct nbl_channel_mgt *)priv;
>  	union nbl_chan_info *chan_info = NBL_CHAN_MGT_TO_CHAN_INFO(chan_mgt);
> +	int ret = 0;
>  
>  	if (chan_info->mailbox.state_bmp) {
> -		rte_bitmap_free(chan_info->mailbox.state_bmp);
> +		ret = rte_bitmap_free(chan_info->mailbox.state_bmp);
> +		if (ret)
> +			NBL_LOG(ERR, "mailbox state bitmap free failed, ret:%d", ret);
>  		chan_info->mailbox.state_bmp = NULL;
>  	}
>  	if (chan_info->mailbox.state_bmp_mem) {

Skip this patch, better to fix rte_bitmap_free() stub to be a void
function; addressed in another patch.