[PATCH] lib/net: Add ICMP support to rte_net_get_ptype()

[Eimear Morrissey]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday 15 October 2025 18:30
> To: Eimear Morrissey <eimear.morrissey at huawei.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] lib/net: Add ICMP support to rte_net_get_ptype()
> 
> On Thu, 9 Oct 2025 16:27:40 +0100
> Eimear Morrissey <eimear.morrissey at huawei.com> wrote:
> 
> > Set RTE_PTYPE_L4_ICMP for ICMP packets.
> >
> > Signed-off-by: Eimear Morrissey <eimear.morrissey at huawei.com>
> 
> Would be good to do ICMP6 as well.


Should an ICMPv6 packet be RTE_PTYPE_L4_ICMP/RTE_PTYPE_INNER_L4_ICMP as well? 

The comments in rte_mbuf_ptype.h are inconsistent, the top level comment with examples suggests that 'version'=6, 'next header'=0x3A
 should be RTE_PYTPE_INNER_L4_ICMP but the comment on RTE_PTYPE_INNER_L4_ICMP itself says  'version'=6, 'next header'=1 ?

-Eimear