[PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h

孙越池 sunyuechi at iscas.ac.cn
Fri Sep 19 18:37:17 CEST 2025


Okay, I initially thought this was common practice across all architectures, but it turns out only x86 added #include "rte_cpuflags.h" here.
I’ve now moved it to lib/fib/dir24_8_rvv.h and updated v3.


> -----原始邮件-----
> 发件人: "Thomas Monjalon" <thomas at monjalon.net>
> 发送时间: 2025-09-19 23:13:19 (星期五)
> 收件人: "Sun Yuechi" <sunyuechi at iscas.ac.cn>
> 抄送: dev at dpdk.org, "Stanislaw Kardach" <stanislaw.kardach at gmail.com>, uk7b at foxmail.com
> 主题: Re: [PATCH v2 2/5] eal/riscv/spinlock: add rte_cpuflag.h
> 
> 01/07/2025 20:20, uk7b at foxmail.com:
> > From: Sun Yuechi <sunyuechi at iscas.ac.cn>
> > 
> > Same as the x86 style, include "rte_cpuflags.h" in rte_spinlock.h
> > so that files like lib/fib/dir24_8.c don’t need to include it.
> > 
> > Signed-off-by: Sun Yuechi <sunyuechi at iscas.ac.cn>
> 
> I disagree.
> I prefer removing useless includes like in x86 spinlock.
> 
</sunyuechi at iscas.ac.cn></sunyuechi at iscas.ac.cn></stanislaw.kardach at gmail.com></sunyuechi at iscas.ac.cn></thomas at monjalon.net>


More information about the dev mailing list