[PATCH v1 00/16] refactoring naming the for exported symbols

Stephen Hemminger stephen at networkplumber.org
Tue Sep 23 18:02:12 CEST 2025


On Fri, 19 Sep 2025 11:14:45 +0200
Serhii Iliushyk <sil-plv at napatech.com> wrote:

> This patch series dedicates to align the naming if the exported symbols in order to avoid
> potential conflicts with other application and libraries.
> The main change is to add the prefix "nthw_".
> 
> Serhii Iliushyk (16):
>   net/ntnic: single file function as static
>   net/ntnic: remove unused functions
>   net/ntnic: move nthw_ to prefix
>   net/ntnic: change prefix hw_ to prefix nthw_
>   net/ntnic: modify prefix flow_ with prefix nthw_
>   net/ntnic: change prefix flm_ to prefix nthw_flm_
>   net/ntnic: change prefix nt_ to prefix nthw_
>   net/ntnic: change prefix ntlog_ to prefix nthw_log
>   net/ntnic: change prefix km_ to prefix nthw_km_
>   net/ntnic: change prefix set_ to prefix nthw_set_
>   net/ntnic: rename common hash and flow functions
>   net/ntnic: rename register ops function
>   net/ntnic: rename get ops functions
>   net/ntnic: rename ops_init functions
>   net/ntnic: rename nim agx setup function
>   net/ntnic: rename table id functions
> 
>  drivers/net/ntnic/adapter/nt4ga_adapter.c     |   14 +-
>  .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c |   10 +-
>  drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c |   54 +-
>  drivers/net/ntnic/include/create_elements.h   |    9 -
>  drivers/net/ntnic/include/flow_api.h          |   10 +-
>  drivers/net/ntnic/include/flow_api_engine.h   |   18 +-
>  drivers/net/ntnic/include/hw_mod_backend.h    |  281 ++--
>  drivers/net/ntnic/include/ntnic_dbs.h         |   22 +-
>  .../link_mgmt/link_100g/nt4ga_link_100g.c     |   14 +-
>  .../link_agx_100g/nt4ga_agx_link_100g.c       |   22 +-
>  drivers/net/ntnic/link_mgmt/nt4ga_link.c      |    2 +-
>  drivers/net/ntnic/nim/i2c_nim.c               |   10 +-
>  drivers/net/ntnic/nim/i2c_nim.h               |    2 +-
>  .../net/ntnic/nthw/core/include/nthw_fpga.h   |   14 +-
>  .../net/ntnic/nthw/core/include/nthw_hif.h    |   12 -
>  .../net/ntnic/nthw/core/include/nthw_iic.h    |    9 -
>  .../ntnic/nthw/core/include/nthw_mac_pcs.h    |    9 -
>  .../net/ntnic/nthw/core/include/nthw_pcie3.h  |   13 -
>  .../nthw/core/include/nthw_pcm_nt400dxx.h     |    1 -
>  .../ntnic/nthw/core/include/nthw_phy_tile.h   |    2 -
>  .../net/ntnic/nthw/core/include/nthw_rpf.h    |    2 -
>  .../net/ntnic/nthw/core/include/nthw_si5340.h |    2 -
>  .../clock_profiles/nthw_fpga_clk9563.c        |    4 +-
>  .../nthw/core/nt200a0x/nthw_fpga_nt200a0x.c   |    8 +-
>  .../core/nt200a0x/reset/nthw_fpga_rst9563.c   |    8 +-
>  .../nt200a0x/reset/nthw_fpga_rst_nt200a0x.c   |    6 +-
>  .../nthw/core/nt400dxx/nthw_fpga_nt400dxx.c   |    8 +-
>  .../core/nt400dxx/reset/nthw_fpga_rst9574.c   |   22 +-
>  .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c   |   36 +-
>  drivers/net/ntnic/nthw/core/nthw_fpga.c       |   22 +-
>  drivers/net/ntnic/nthw/core/nthw_hif.c        |   90 --
>  drivers/net/ntnic/nthw/core/nthw_i2cm.c       |    4 +-
>  drivers/net/ntnic/nthw/core/nthw_igam.c       |    4 +-
>  drivers/net/ntnic/nthw/core/nthw_iic.c        |  240 +--
>  drivers/net/ntnic/nthw/core/nthw_mac_pcs.c    |   67 +-
>  drivers/net/ntnic/nthw/core/nthw_pcie3.c      |   86 --
>  .../net/ntnic/nthw/core/nthw_pcm_nt400dxx.c   |    5 -
>  drivers/net/ntnic/nthw/core/nthw_phy_tile.c   |   51 +-
>  drivers/net/ntnic/nthw/core/nthw_rpf.c        |   14 -
>  .../net/ntnic/nthw/core/nthw_si5332_si5156.c  |    2 +-
>  drivers/net/ntnic/nthw/core/nthw_si5340.c     |    6 +-
>  drivers/net/ntnic/nthw/core/nthw_spi_v3.c     |   12 +-
>  drivers/net/ntnic/nthw/dbs/nthw_dbs.c         |   22 +-
>  drivers/net/ntnic/nthw/flow_api/flow_api.c    |  253 ++--
>  .../nthw/flow_api/flow_backend/flow_backend.c | 1342 ++++++++---------
>  drivers/net/ntnic/nthw/flow_api/flow_filter.c |    4 +-
>  .../net/ntnic/nthw/flow_api/flow_hsh_cfg.c    |   46 +-
>  .../net/ntnic/nthw/flow_api/flow_hsh_cfg.h    |    2 +-
>  .../net/ntnic/nthw/flow_api/flow_id_table.c   |   10 +-
>  .../net/ntnic/nthw/flow_api/flow_id_table.h   |   10 +-
>  drivers/net/ntnic/nthw/flow_api/flow_kcc.c    |    2 +-
>  drivers/net/ntnic/nthw/flow_api/flow_km.c     |  134 +-
>  .../nthw/flow_api/hw_mod/hw_mod_backend.c     |   18 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_cat.c   |  356 ++---
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_flm.c   |   70 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c   |   14 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_km.c    |  107 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_pdb.c   |   40 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_qsl.c   |   32 +-
>  .../nthw/flow_api/hw_mod/hw_mod_slc_lr.c      |   14 +-
>  .../ntnic/nthw/flow_api/hw_mod/hw_mod_tpe.c   |   80 +-
>  .../flow_api/profile_inline/flm_age_queue.c   |   22 +-
>  .../flow_api/profile_inline/flm_age_queue.h   |   20 +-
>  .../flow_api/profile_inline/flm_lrn_queue.c   |   12 +-
>  .../flow_api/profile_inline/flm_lrn_queue.h   |   12 +-
>  .../profile_inline/flow_api_hw_db_inline.c    | 1138 +++++++-------
>  .../profile_inline/flow_api_hw_db_inline.h    |   99 +-
>  .../profile_inline/flow_api_profile_inline.c  |  596 ++++----
>  .../profile_inline/flow_api_profile_inline.h  |   49 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_cat.c    |  230 +--
>  .../ntnic/nthw/flow_filter/flow_nthw_cat.h    |  230 +--
>  .../ntnic/nthw/flow_filter/flow_nthw_csu.c    |   22 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_csu.h    |   24 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_flm.c    |  278 ++--
>  .../ntnic/nthw/flow_filter/flow_nthw_flm.h    |  278 ++--
>  .../ntnic/nthw/flow_filter/flow_nthw_hfu.c    |   58 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_hfu.h    |   58 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_hsh.c    |   60 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_hsh.h    |   60 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_ifr.c    |   30 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_ifr.h    |   30 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_info.c   |   88 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_info.h   |   88 +-
>  .../net/ntnic/nthw/flow_filter/flow_nthw_km.c |  160 +-
>  .../net/ntnic/nthw/flow_filter/flow_nthw_km.h |  162 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_pdb.c    |   54 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_pdb.h    |   56 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_qsl.c    |   68 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_qsl.h    |   68 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c |   32 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_rpp_lr.h |   32 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_slc_lr.c |   28 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_slc_lr.h |   28 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_cpy.c |   22 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_cpy.h |   22 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_ins.c |   20 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_ins.h |   20 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_rpl.c |   42 +-
>  .../ntnic/nthw/flow_filter/flow_nthw_tx_rpl.h |   46 +-
>  .../net/ntnic/nthw/model/nthw_fpga_model.c    |  577 +++----
>  .../net/ntnic/nthw/model/nthw_fpga_model.h    |   28 -
>  drivers/net/ntnic/nthw/nthw_platform.c        |    2 +-
>  drivers/net/ntnic/nthw/nthw_platform_drv.h    |    2 +-
>  drivers/net/ntnic/nthw/nthw_rac.c             |   28 +-
>  .../net/ntnic/nthw/ntnic_meter/ntnic_meter.c  |   20 +-
>  .../nthw/supported/nthw_fpga_mod_str_map.c    |    2 +-
>  .../nthw/supported/nthw_fpga_mod_str_map.h    |    2 +-
>  drivers/net/ntnic/ntlog/ntlog.c               |    6 +-
>  drivers/net/ntnic/ntlog/ntlog.h               |    6 +-
>  drivers/net/ntnic/ntnic_ethdev.c              |  108 +-
>  drivers/net/ntnic/ntnic_filter/ntnic_filter.c |   49 +-
>  drivers/net/ntnic/ntnic_mod_reg.c             |   96 +-
>  drivers/net/ntnic/ntnic_mod_reg.h             |  142 +-
>  drivers/net/ntnic/ntnic_vfio.c                |   18 +-
>  drivers/net/ntnic/ntnic_vfio.h                |   12 +-
>  drivers/net/ntnic/ntnic_xstats/ntnic_xstats.c |    4 +-
>  drivers/net/ntnic/ntutil/nt_util.c            |   73 +-
>  drivers/net/ntnic/ntutil/nt_util.h            |   21 +-
>  118 files changed, 4434 insertions(+), 4887 deletions(-)
> 

Looks good but I ended up pulling out the ntnic driver service changes
because of the error detected on build with fortify (string format overflow).

When you resubmit the ntnic driver you can either merge these
changes into that, or just add these patches as after thought.



More information about the dev mailing list