[PATCH v3 4/7] gpudev: fix driver header for Windows

[David Marchand]

Hello Bruce,

On Thu, 25 Sept 2025 at 09:53, Bruce Richardson
<bruce.richardson at intel.com> wrote:
>
> On Wed, Sep 24, 2025 at 07:25:32PM +0200, David Marchand wrote:
> > Use rte_os.h and its RTE_TAILQ_HEAD definition compatible with BSD
> > sys/queue.h
> >
> > Fixes: 18cb07563165 ("gpudev: add event notification")
> >
> > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > ---
> >  lib/gpudev/gpudev.c        | 1 +
> >  lib/gpudev/gpudev_driver.h | 4 ++--
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c
> > index 0473d9ffb3..4a2335834c 100644
> > --- a/lib/gpudev/gpudev.c
> > +++ b/lib/gpudev/gpudev.c
> > @@ -3,6 +3,7 @@
> >   */
> >
> >  #include <stdlib.h>
> > +#include <sys/queue.h>
> >
> >  #include <eal_export.h>
> >  #include <rte_eal.h>
>
> A bit confused. Why do we add sys/queue.h here but replace it below with
> rte_os.h?

I only fixed the minimum possible in the exported header.

To reuse rte_os.h here, I would have to change more code in the
library as this code uses the sys/queue.h API.
(EAL Windows provides one for internal consumption, if you did not
notice, see lib/eal/windows/include).


-- 
David Marchand