[PATCH v2] pcapng: allow any protocol link type for the interface block

Thomas Monjalon thomas at monjalon.net
Sat Sep 27 11:28:37 CEST 2025


26/09/2025 02:04, Stephen Hemminger:
> On Wed, 27 Aug 2025 16:32:15 -0600
> Schneide <schneide at qti.qualcomm.com> wrote:
> 
> >  
> > +* pcapng: Changed the API for adding interfaces to include a link type argument.
> > +  The link type was previously hardcoded to the ethernet link type in the API.
> > +  This argument is added to ``rte_pcapng_add_interface``.
> > +  These functions are versioned to retain binary compatibility until the next LTS release.
> 
> Since link connector is now merged, and that wording might overlap and
> be confusing. Would be could to add reference to pcap-linktype.7 man
> page.

I'm not sure it overlaps.
RTE_ETH_LINK_CONNECTOR is about Ethernet cables while
pcap link type will be simply Ethernet type.

This being said, I don't understand the immediate benefit of this commit.
Why pcap link type would not be always Ethernet in DPDK case?
I think the only benefit is for future if other link types are added.
Is there something else I'm missing?




More information about the dev mailing list