[PATCH v7 0/8] net/nfb: rework to real multiport

[Stephen Hemminger]

On Wed,  4 Feb 2026 13:31:29 +0100
spinler at cesnet.cz wrote:

> From: Martin Spinler <spinler at cesnet.cz>
> 
> This series implements real multiport for better user experience.
> 
> The existing driver creates one ethdev/port for one PCI device.
> As the CESNET-NDK based cards aren't capable to represent each
> Ethernet port by own PCI device, new driver implementation
> processes real port configuration from firmware/card and switches
> from rte_eth_dev_pci_generic_probe to multiple rte_eth_dev_create calls.
> 
> ---
Patch 1/8 (Queue Mapping):

    Missing NULL checks before accessing queue_map_rx/tx arrays (could crash in secondary process)
    Missing bounds checks on queue indices (buffer overflow risk)

Patch 2/8 (Core Refactoring):

    Resource leak: nfb_dev not closed on error path
    NULL pointer dereference: no check after rte_eth_dev_get_by_name()
    Array overflow in queue mapping initialization
    Partial device cleanup missing on errors

Patch 4/8 (Port Argument):

    Missing errno check after strtoul() conversion

Quick Summary: The architectural refactoring is well-designed but needs defensive programming additions. Most issues are missing validation checks that could cause crashes or leaks on error paths.

Detailed review attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bundle-1748-review.md
Type: text/markdown
Size: 10345 bytes
Desc: not available
URL: <http://mails.dpdk.org/archives/dev/attachments/20260209/664a9dbb/attachment-0001.md>