回复: [PATCH v2 01/12] net/r8169: fix NULL pointer dereference in rtl8168fp_ops

[王颢]

Thanks. Since I need to send a v3 to address comments on another patch in this series, I will include this updated commit message in v3.


-----邮件原件-----
发件人: Stephen Hemminger <stephen at networkplumber.org> 
发送时间: 2026年2月12日 5:43
收件人: 王颢 <howard_wang at realsil.com.cn>
抄送: dev at dpdk.org; pro_nic_dpdk at realtek.com
主题: Re: [PATCH v2 01/12] net/r8169: fix NULL pointer dereference in rtl8168fp_ops


External mail : This email originated from outside the organization. Do not reply, click links, or open attachments unless you recognize the sender and know the content is safe.



On Tue, 10 Feb 2026 13:55:00 +0800
Howard Wang <howard_wang at realsil.com.cn> wrote:

> Fixes: d9ee71b5f1bc ("net/r8169: support RTL8168 series")
>
> Signed-off-by: Howard Wang <howard_wang at realsil.com.cn>
> ---

That is much to short a message for a critical fix.
How about this (AI generated) message. Can I add that during merge?

Subject: [PATCH v2 01/12] net/r8169: fix crash in RTL8168FP init

The rtl8168fp_ops structure was missing the hw_phy_mcu_config function pointer, causing a NULL pointer dereference during device initialization when the driver attempts to configure the PHY microcontroller.

Add hw_phy_mcu_config_8168fp() as a no-op function since the RTL8168FP does not require PHY MCU configuration. This matches the pattern used by other chip variants that don't need PHY MCU updates.

Fixes: d9ee71b5f1bc ("net/r8169: support RTL8168 series")