[PATCH] drivers: disable comma warnings selectively
Bruce Richardson
bruce.richardson at intel.com
Fri Feb 13 18:35:27 CET 2026
On Fri, Feb 13, 2026 at 09:25:17AM -0800, Stephen Hemminger wrote:
> On Fri, 13 Feb 2026 15:14:00 +0000
> Bruce Richardson <bruce.richardson at intel.com> wrote:
>
> > Rather than disabling -Wcomma for all drivers, only disable it on a
> > case-by-case basis for drivers that need it disabled. Use a variable to
> > do so, to avoid issues with compilers like MSVC that don't support the
> > -Wno-comma flag.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
>
> Some of those drivers should be easy to fix?
>
Yep.
Unfortunately there are lots of CI errors with this patch because I forgot
that the Intel driver cleanups are still on next-net-intel tree rather than
main.
For other drivers, I didn't actually take time to investigate fixing these,
I was mainly interested in the scope of the problem and ensuring that any
drivers that are without issues stay that way. It was only after it was
done that I realised how few problems there actually are.
> This change would be helped by fixing and introducing FOREACH_SAFE macros.
> I started that but it never got anywhere
Right. However, it's not a really big blocker here. Quick fixes to remove
the use of comma can be done without a major refactor.
/Bruce
More information about the dev
mailing list