[PATCH v2 2/4] test: check SFF-8636 lane status flags

[Roman Khromenok]

Check that the SFF-8636 lane status flags are not reported
if the module does not advertise them, except the Rx loss of
signal which is always reported, that they are reported as "None"
if no lane is flagged, and that each lane is mapped to the
right bit of the flag bytes.

Signed-off-by: Roman Khromenok <roma55592 at yandex.ru>
---
 app/test/test_ethdev_module_eeprom.c | 78 ++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

diff --git a/app/test/test_ethdev_module_eeprom.c b/app/test/test_ethdev_module_eeprom.c
index 1956fdd440..1cad8ede97 100644
--- a/app/test/test_ethdev_module_eeprom.c
+++ b/app/test/test_ethdev_module_eeprom.c
@@ -243,6 +243,82 @@ test_module_eeprom_qsfp_8636_thresholds(void)
 	return TEST_SUCCESS;
 }
 
+/* SFF-8636 lower page channel status flags and their implemented bits */
+#define QSFP_LOS_FLAGS		3
+#define QSFP_FAULT_FLAGS	4
+#define QSFP_LOL_FLAGS		5
+#define QSFP_OPTIONS_2		193
+#define QSFP_OPTIONS_3		194
+#define QSFP_OPTIONS_4		195
+
+static void
+fill_qsfp_signals(uint8_t *data)
+{
+	fill_qsfp(data);
+	data[QSFP_OPTIONS_2] |= 0x08;	/* Tx adaptive equalizers */
+	data[QSFP_OPTIONS_3] |= 0x30;	/* Tx and Rx CDR loss of lock */
+	data[QSFP_OPTIONS_4] |= 0x0a;	/* Tx fault and Tx loss of signal */
+}
+
+static int
+test_module_eeprom_qsfp_8636_signals_not_implemented(void)
+{
+	uint8_t data[RTE_ETH_MODULE_SFF_8636_LEN];
+
+	/* flags are raised but the module does not advertise them */
+	fill_qsfp(data);
+	data[QSFP_LOS_FLAGS] = 0xff;
+	data[QSFP_FAULT_FLAGS] = 0xff;
+	data[QSFP_LOL_FLAGS] = 0xff;
+
+	TEST_ASSERT_SUCCESS(parse(RTE_ETH_MODULE_SFF_8636, data, sizeof(data)),
+		"Failed to parse SFF-8636 data");
+	/* Rx LOS has no implemented bit and is always reported */
+	CHECK_FIELD("Rx loss of signal", "[ Yes, Yes, Yes, Yes ]");
+	CHECK_NO_FIELD("Tx loss of signal");
+	CHECK_NO_FIELD("Rx loss of lock");
+	CHECK_NO_FIELD("Tx loss of lock");
+	CHECK_NO_FIELD("Tx fault");
+	CHECK_NO_FIELD("Tx adaptive eq fault");
+	return TEST_SUCCESS;
+}
+
+static int
+test_module_eeprom_qsfp_8636_signals(void)
+{
+	uint8_t data[RTE_ETH_MODULE_SFF_8636_LEN];
+
+	fill_qsfp_signals(data);
+	TEST_ASSERT_SUCCESS(parse(RTE_ETH_MODULE_SFF_8636, data, sizeof(data)),
+		"Failed to parse SFF-8636 data without flags");
+	CHECK_FIELD("Rx loss of signal", "None");
+	CHECK_FIELD("Tx loss of signal", "None");
+	CHECK_FIELD("Rx loss of lock", "None");
+	CHECK_FIELD("Tx loss of lock", "None");
+	CHECK_FIELD("Tx fault", "None");
+	CHECK_FIELD("Tx adaptive eq fault", "None");
+
+	/* lane 1 is in the lowest bit of each half of the flag byte */
+	data[QSFP_LOS_FLAGS] = 0x21;	/* Rx lane 1, Tx lane 2 */
+	data[QSFP_FAULT_FLAGS] = 0x84;	/* Tx fault lane 3, Tx adaptive eq lane 4 */
+	data[QSFP_LOL_FLAGS] = 0x18;	/* Rx lane 4, Tx lane 1 */
+	TEST_ASSERT_SUCCESS(parse(RTE_ETH_MODULE_SFF_8636, data, sizeof(data)),
+		"Failed to parse SFF-8636 data with flags");
+	CHECK_FIELD("Rx loss of signal", "[ Yes, No, No, No ]");
+	CHECK_FIELD("Tx loss of signal", "[ No, Yes, No, No ]");
+	CHECK_FIELD("Rx loss of lock", "[ No, No, No, Yes ]");
+	CHECK_FIELD("Tx loss of lock", "[ Yes, No, No, No ]");
+	CHECK_FIELD("Tx fault", "[ No, No, Yes, No ]");
+	CHECK_FIELD("Tx adaptive eq fault", "[ No, No, No, Yes ]");
+
+	data[QSFP_LOS_FLAGS] = 0x0f;	/* Rx on all lanes, no Tx */
+	TEST_ASSERT_SUCCESS(parse(RTE_ETH_MODULE_SFF_8636, data, sizeof(data)),
+		"Failed to parse SFF-8636 data with Rx LOS on all lanes");
+	CHECK_FIELD("Rx loss of signal", "[ Yes, Yes, Yes, Yes ]");
+	CHECK_FIELD("Tx loss of signal", "None");
+	return TEST_SUCCESS;
+}
+
 static int
 test_module_eeprom_sfp_8472_ext_cal_unaligned(void)
 {
@@ -453,6 +529,8 @@ static struct unit_test_suite module_eeprom_testsuite = {
 		TEST_CASE(test_module_eeprom_sfp_8472_cal_round),
 		TEST_CASE(test_module_eeprom_qsfp_8636),
 		TEST_CASE(test_module_eeprom_qsfp_8636_thresholds),
+		TEST_CASE(test_module_eeprom_qsfp_8636_signals_not_implemented),
+		TEST_CASE(test_module_eeprom_qsfp_8636_signals),
 		TEST_CASE(test_module_eeprom_invalid),
 		TEST_CASES_END()
 	}
-- 
2.47.3