[PATCH v3 13/29] crypto/virtio: update comment reference to rte_smp_rmb

Stephen Hemminger stephen at networkplumber.org
Fri Oct 9 01:35:06 CEST 2026


The rte_smp_rmb helper is no longer used.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/crypto/virtio/virtqueue.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/virtio/virtqueue.h b/drivers/crypto/virtio/virtqueue.h
index 97a3ace48c..6ef40d3593 100644
--- a/drivers/crypto/virtio/virtqueue.h
+++ b/drivers/crypto/virtio/virtqueue.h
@@ -302,11 +302,11 @@ virtqueue_nused(const struct virtqueue *vq)
 
 	if (vq->hw->weak_barriers) {
 	/**
-	 * x86 prefers to using rte_smp_rmb over rte_atomic_load_explicit as it
+	 * x86 prefers virtio_rmb over rte_atomic_load_explicit as it
 	 * reports a slightly better perf, which comes from the saved
-	 * branch by the compiler.
-	 * The if and else branches are identical with the smp and io
-	 * barriers both defined as compiler barriers on x86.
+	 * branch by the compiler: on x86 this makes the two branches
+	 * identical, since virtio_rmb(0) is rte_io_rmb(), only a
+	 * compiler barrier, and loads are not reordered with loads.
 	 */
 #ifdef RTE_ARCH_X86_64
 		idx = vq->vq_split.ring.used->idx;
-- 
2.53.0



More information about the dev mailing list