[PATCH RESEND] examples/vm_power_manager: add missing <stdlib.h> header include for strtol
Thomas Monjalon
thomas at monjalon.net
Tue Oct 13 14:54:32 CEST 2026
29/08/2026 00:18, Stephen Hemminger:
> On Fri, 28 Aug 2026 23:53:50 +0200
> Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
>
> > From: Guillaume Gardet <Guillaume.Gardet at arm.com>
> >
> > strtol is defined in stdlib.h
> >
> > Fixes the following build failure:
> >
> > ../examples/vm_power_manager/guest_cli/vm_power_cli_guest.c: In function ‘cmd_query_freq_list_parsed’:
> > ../examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:208:42: error: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration]
> > 208 | lcore_id = (unsigned int)strtol(res->cpu_num, &ep, 10);
> > | ^~~~~~
> > | strtok
> >
> > Fixes: 0e8f47491f090f44a4956429cb27f6942b6618b0 ("examples/vm_power: add command to query CPU frequency")
> > Signed-off-by: Guillaume Gardet <guillaume.gardet at arm.com>
> > [Thomas:
> > - retrieve patch from
> > https://build.opensuse.org/projects/openSUSE:42:Factory-Candidates-Check/packages/dpdk/files/0001-examples-vm_power_manager-add-missing-header.patch?expand=1
> > - improve commit message]
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> > ---
> > examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > index 4114593cee..63a59c8b10 100644
> > --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> > @@ -6,6 +6,7 @@
> > #include <stdint.h>
> > #include <string.h>
> > #include <stdio.h>
> > +#include <stdlib.h>
> > #include <termios.h>
> >
> > #include <cmdline_rdline.h>
>
> There is a pre-existing bug here. strtol() can returned signed value.
> Probably should be using strtoul
I assume this patch is superseded by the 2 patches Stephen sent.
More information about the dev
mailing list