[PATCH] net/ixgbe: avoid private driver include in testpmd

Burakov, Anatoly anatoly.burakov at intel.com
Thu Oct 15 12:41:13 CEST 2026


On 10/15/2026 11:13 AM, Thomas Monjalon wrote:
> 15/10/2026 10:53, Burakov, Anatoly:
>> On 10/14/2026 10:34 PM, Thomas Monjalon wrote:
>>> Testpmd commands should use the driver's public API
>>> rather than access its private structures directly.
>>> Note: ixgbe_testpmd.c should be considered as part of testpmd.
>>>
>>> ixgbe_testpmd.c includes ixgbe_ethdev.h only to check whether bypass
>>> operations are available through the private adapter structure.
>>>
>>> Rely on the public bypass API to check availability
>>> and handle -ENOTSUP in the commands.
>>> Remove ixgbe_ethdev.h, ethdev_driver.h
>>> and the now unnecessary RTE_LIBRTE_IXGBE_BYPASS definition.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
>>> ---
>>
>> Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
> 
> I forgot to say it is mostly written by AI.
> I didn't review it myself.
> Please double check.

It doesn't look wrong to me, testpmd code should not be using 
driver-internal things anyway except through pmd-specific API, which is 
what this patch does.

-- 
Thanks,
Anatoly


More information about the dev mailing list