[PATCH 2/2] drivers: add support for async RTE FLOW APIs
Stephen Hemminger
stephen at networkplumber.org
Wed Sep 23 20:39:10 CEST 2026
On Wed, 15 Jul 2026 14:15:20 +0530
<ykanaujia at marvell.com> wrote:
> From: Yashaswini Kanaujia <ykanaujia at marvell.com>
>
> added support for asynchronous rte_flow APIs
> for cn10k device
>
> Signed-off-by: Yashaswini Kanaujia <ykanaujia at marvell.com>
> ---
AI review found issues with the patch.
f58b114027 "net/cnxk: support async flow API" — the code is genuinely
well-written; I found no memory-safety defects. Bounds on nb_items/nb_actions are
enforced at template creation with comments naming the fixed-size stack arrays
they protect, template indices and queue_id are checked at every entry point,
refcounts prevent destroy-while-in-use, and create_by_index is a deliberate
ENOTSUP stub rather than an unfinished path.
The problems are process ones: the message says "for cn10k device" but the patch
also wires up cn20k; ~3200 lines as a single commit with a 2-line message; no
release notes and no cnxk.ini feature-flag update for a new user-visible feature;
and a stray blank line removed at cn20k_ethdev.c:8.
More information about the dev
mailing list