[PATCH 2/2] net/cnxk: remove redundant IP reassembly conf get stubs
Stephen Hemminger
stephen at networkplumber.org
Thu Sep 24 18:09:24 CEST 2026
cn10k_nix_reassembly_conf_get() and cn20k_nix_reassembly_conf_get() only
return -ENOTSUP, and they are the only writers of
cnxk_eth_dev_ops.ip_reassembly_conf_get in the tree. The field has no
initialiser in cnxk_eth_dev_ops, so dropping the assignments leaves it
NULL and rte_eth_ip_reassembly_conf_get() returns -ENOTSUP as before.
The sibling ip_reassembly_conf_set and ip_reassembly_capability_get ops
are real implementations and are left alone.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/cnxk/cn10k_ethdev.c | 10 ----------
drivers/net/cnxk/cn20k_ethdev.c | 10 ----------
2 files changed, 20 deletions(-)
diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c
index bcf4e23286..3f987a8195 100644
--- a/drivers/net/cnxk/cn10k_ethdev.c
+++ b/drivers/net/cnxk/cn10k_ethdev.c
@@ -645,15 +645,6 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
return rc;
}
-static int
-cn10k_nix_reassembly_conf_get(struct rte_eth_dev *eth_dev,
- struct rte_eth_ip_reassembly_params *conf)
-{
- RTE_SET_USED(eth_dev);
- RTE_SET_USED(conf);
- return -ENOTSUP;
-}
-
static int
cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
const struct rte_eth_ip_reassembly_params *conf)
@@ -883,7 +874,6 @@ nix_eth_dev_ops_override(void)
cn10k_nix_timesync_read_tx_timestamp;
cnxk_eth_dev_ops.ip_reassembly_capability_get =
cn10k_nix_reassembly_capability_get;
- cnxk_eth_dev_ops.ip_reassembly_conf_get = cn10k_nix_reassembly_conf_get;
cnxk_eth_dev_ops.ip_reassembly_conf_set = cn10k_nix_reassembly_conf_set;
cnxk_eth_dev_ops.eth_rx_descriptor_dump = cn10k_rx_descriptor_dump;
}
diff --git a/drivers/net/cnxk/cn20k_ethdev.c b/drivers/net/cnxk/cn20k_ethdev.c
index 9fac027650..c1a7916e6f 100644
--- a/drivers/net/cnxk/cn20k_ethdev.c
+++ b/drivers/net/cnxk/cn20k_ethdev.c
@@ -629,15 +629,6 @@ cn20k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
return 0;
}
-static int
-cn20k_nix_reassembly_conf_get(struct rte_eth_dev *eth_dev,
- struct rte_eth_ip_reassembly_params *conf)
-{
- RTE_SET_USED(eth_dev);
- RTE_SET_USED(conf);
- return -ENOTSUP;
-}
-
static int
cn20k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
const struct rte_eth_ip_reassembly_params *conf)
@@ -928,7 +919,6 @@ nix_eth_dev_ops_override(void)
cnxk_eth_dev_ops.timesync_disable = cn20k_nix_timesync_disable;
cnxk_eth_dev_ops.timesync_read_tx_timestamp = cn20k_nix_timesync_read_tx_timestamp;
cnxk_eth_dev_ops.ip_reassembly_capability_get = cn20k_nix_reassembly_capability_get;
- cnxk_eth_dev_ops.ip_reassembly_conf_get = cn20k_nix_reassembly_conf_get;
cnxk_eth_dev_ops.ip_reassembly_conf_set = cn20k_nix_reassembly_conf_set;
cnxk_eth_dev_ops.eth_rx_descriptor_dump = cn20k_rx_descriptor_dump;
}
--
2.53.0
More information about the dev
mailing list