<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-IT" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">> From: Stephen Hemminger <stephen@networkplumber.org><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> Date: Thursday, 18 November 2021 at 17:21<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> To: Elena Agostini <eagostini@nvidia.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> Cc: dev@dpdk.org <dev@dpdk.org><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> Subject: Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> External email: Use caution opening links or attachments>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> On Thu, 18 Nov 2021 19:28:02 +0000<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> <eagostini@nvidia.com> wrote:>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > index 2b174d8bd5..97575ed979 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > --- a/lib/gpudev/gpudev.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > +++ b/lib/gpudev/gpudev.c<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > @@ -576,6 +576,11 @@ rte_gpu_mem_free(int16_t dev_id, void *ptr)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > return -rte_errno;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> ><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > + if (ptr == NULL) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > + rte_errno = EINVAL;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > + return -rte_errno;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > + }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> > +> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> The convention for free(), and rte_free() is that calling free<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> with a NULL pointer is a nop. Why not follow those?>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> This would keep programmers from having to view GPU as a<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">> special case.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt">Please look at v2 here
<a href="https://patches.dpdk.org/project/dpdk/patch/20211118203354.25355-1-eagostini@nvidia.com/">
https://patches.dpdk.org/project/dpdk/patch/20211118203354.25355-1-eagostini@nvidia.com/</a>
<o:p></o:p></span></p>
</div>
</div>
</body>
</html>