<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Zhang, Roy Fan <roy.fan.zhang@intel.com> Sent: Thursday, December 16, 2021 4:05 PM To: Akhil Goyal <gakhil@marvell.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Anoob Joseph <anoobj@marvell.com> Cc: dev@dpdk.org; Ramkumar Balu <rbalu@marvell.com> Subject: RE: [RFC] Cryptodev: use rte_crypto_vec, group big-endian constraints<o:p></o:p> </div> </div> <o:p> </o:p> Hi,<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Akhil Goyal <<a href="mailto:gakhil@marvell.com">gakhil@marvell.com</a>> Sent: Monday, December 13, 2021 9:36 AM To: Kusztal, ArkadiuszX <<a href="mailto:arkadiuszx.kusztal@intel.com">arkadiuszx.kusztal@intel.com</a>>; Anoob Joseph <<a href="mailto:anoobj@marvell.com">anoobj@marvell.com</a>>; Zhang, Roy Fan <<a href="mailto:roy.fan.zhang@intel.com">roy.fan.zhang@intel.com</a>> Cc: <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>; Ramkumar Balu <<a href="mailto:rbalu@marvell.com">rbalu@marvell.com</a>> Subject: RE: [RFC] Cryptodev: use rte_crypto_vec, group big-endian constraints<o:p></o:p> </div> </div> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <o:p> </o:p> Hi, <o:p></o:p> since DPDK 21.11 is out, we should start discussion to make asymmetric API stable.<o:p></o:p> <o:p> </o:p> - Struct rte_crypto_vec vs struct rte_crypto_param_t<o:p></o:p> <o:p> </o:p> We have two almost identical functionally structs, one in _sym.h another in asym.h so we probably should pick one of them.<o:p></o:p> “rte_crypto_vec” additionally contains total length which will be useful information as PMD will overwrite “len” in many cases.<o:p></o:p> Unfortunately as “rte_crypto.h” includes “_sym.h” and “_asym.h” not other way around we cannot move it to “rte_crypto.h” but asymmetric will include symmetric anyway so it probably will not be that big of an issue.<o:p></o:p> [Akhil ] +1<o:p></o:p> [Fan] +1 <o:p></o:p> <o:p> </o:p> - Network byte order<o:p></o:p> <o:p> </o:p> rte_crypto_param dP; /**<<o:p></o:p> /**< dP - Private CRT component<o:p></o:p> * Private CRT component of RSA parameter required for CRT method<o:p></o:p> * RSA private key operations in Octet-string network byte order<o:p></o:p> * format.<o:p></o:p> * dP = d mod ( p - 1 )<o:p></o:p> */<o:p></o:p> We have plenty of these (sometimes in places where should not be, and not in places where should). Every member that contains this comment here is a big integer in big-endian format.<o:p></o:p> We could simplify it to:<o:p></o:p> <o:p> </o:p> /** Big integer in big-endian format */<o:p></o:p> typedef struct rte_crypto_vec rte_crypto_bigint; <o:p></o:p> <o:p> </o:p> rte_crypto_bigint dP; /**< d mod ( p - 1 ) */<o:p></o:p> <o:p> </o:p> ED related algorithms like (EDDSA) will use little-endian bit integers so it will have to use different approach.<o:p></o:p> <o:p> </o:p> [Akhil] Using different approaches for endianness may not be a good idea. Why can’t we use rte_crypto_vec for LE? It has a void * data. Right?<o:p></o:p> [Fan] Akhil, do you believe a comment before the param is enough?<o:p></o:p> [Arek] – Yes, for me it would be rte_crypto_vec for LE and rte_crypto_bigint for BE, which would correspond to what other crypto libraries propose.<o:p></o:p> </div> </div> </div> </div> </body> </html>