<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +++ b/lib/eal/include/rte_compat.h<br>
> @@ -33,8 +33,11 @@ section(".text.internal")))<br>
>  #elif !defined ALLOW_INTERNAL_API && __has_attribute(diagnose_if) /*<br>
> For clang */<br>
<br>
Why doesn't the __has_attribute take care of this?<br>
I would have thought that gcc would check the for the attribute, find it<br>
doesn't support it and ignore the whole thing?<br></blockquote><div><br></div><div style="font-size:small" class="gmail_default">It appears that the '-Wgcc-compat' check is too naive and doesn't pick up the `__has_attribute` or `#if __clang__` and realise that there isn't really a compatibility issue with the code.</div><div style="font-size:small" class="gmail_default"><br></div><div style="font-size:small" class="gmail_default">Mike.<br></div><br></div></div>