<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal">Hi Srinivas:<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">This is the fix for PF driver only, for VF we have a separated fix and it is not be captured in 20.11.3, but I saw the patches are already merged in stable tree.<o:p></o:p></p> <p class="MsoNormal">You can try with latest 20.11.4-rc1, or wait for 20.11.4 LTS.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Regards<o:p></o:p></p> <p class="MsoNormal">Qi<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Navin Srinivas <g.navinsrinivas@gmail.com> <br> <b>Sent:</b> Tuesday, February 22, 2022 11:56 AM<br> <b>To:</b> Zhang, Qi Z <qi.z.zhang@intel.com><br> <b>Cc:</b> Wang, Yixue <yixue.wang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Liheng <liheng.zhang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org; stable@dpdk.org<br> <b>Subject:</b> Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">Hi, <o:p></o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not see PF crash on 20.11.3, <o:p></o:p></p> </div> <div> <p class="MsoNormal">I'm seeing a crash on the secondary process when it receives packet on the VF, but PF doesn't crash now on 20.11.3<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">So I suspect this is the patch which is fixing the issue on ICE secondary process crash on PF.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Thanks & Regards,<o:p></o:p></p> </div> <div> <p class="MsoNormal">Navin Srinivas<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com">qi.z.zhang@intel.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal" style="margin-bottom:12.0pt"><br> <br> > -----Original Message-----<br> > From: Wang, Yixue <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>><br> > Sent: Thursday, June 3, 2021 6:04 PM<br> > To: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>; Yang, Qiming<br> > <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>><br> > Cc: Zhang, Liheng <<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a>>; Dong, Yao<br> > <<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a>>; <a href="mailto:dev@dpdk.org" target="_blank"> dev@dpdk.org</a>; <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><br> > Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary<br> > process<br> > <br> > Hi, Qi<br> > <br> > I've tested this patch and it works.<br> > <br> > Best Regards,<br> > Yixue.<br> > <br> > > -----Original Message-----<br> > > From: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>><br> > > Sent: Monday, May 24, 2021 17:08<br> > > To: Yang, Qiming <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>><br> > > Cc: Zhang, Liheng <<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a>>; Wang, Yixue<br> > > <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>; Dong, Yao <<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a>>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>;<br> > > Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>; <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><br> > > Subject: [PATCH] net/ice: fix wrong data path selection in secondary<br> > > process<br> > ><br> > > The flag use_avx2 and use_avx512 are defined as local variables, they<br> > > will not be aware by the secondary process, then wrong data path is<br> > > selected. Fix the issue by moving them into struct ice_adapter.<br> > ><br> > > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")<br> > > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx")<br> > > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")<br> > > Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><br> > ><br> > > Reported-by: Yixue Wang <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>><br> > > Signed-off-by: Qi Zhang <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>><br> <br> Tested-by: Yixue Wang <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>><br> <br> Applied to dpdk-next-net-intel.<br> <br> Thanks<br> Qi<o:p></o:p></p> </blockquote> </div> </div> </div> </div> </body> </html>