<div dir="ltr"><div dir="ltr">Thanks, I noticed it in the release and took the LTS version. </div><div dir="ltr">I do not see the previously noticed VF crash now on 20.11.4<div> </div><div>Navin</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 22, 2022 at 2:51 PM Kevin Traynor <<a href="mailto:ktraynor@redhat.com">ktraynor@redhat.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 22/02/2022 04:30, Zhang, Qi Z wrote: > Hi Srinivas: > > This is the fix for PF driver only, for VF we have a separated fix and it is not be captured in 20.11.3, but I saw the patches are already merged in stable tree. > You can try with latest 20.11.4-rc1, or wait for 20.11.4 LTS. > 20.11.4 is already released. Xueming sent details here <a href="http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u" rel="noreferrer" target="_blank">http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u</a> You can check the release notes (or git) for specific fixes <a href="https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11" rel="noreferrer" target="_blank">https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11</a> > Regards > Qi > > From: Navin Srinivas <<a href="mailto:g.navinsrinivas@gmail.com" target="_blank">g.navinsrinivas@gmail.com</a>> > Sent: Tuesday, February 22, 2022 11:56 AM > To: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>> > Cc: Wang, Yixue <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>; Yang, Qiming <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>>; Zhang, Liheng <<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a>>; Dong, Yao <<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a>>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>; <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process > > Hi, > > Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not see PF crash on 20.11.3, > I'm seeing a crash on the secondary process when it receives packet on the VF, but PF doesn't crash now on 20.11.3 > > So I suspect this is the patch which is fixing the issue on ICE secondary process crash on PF. > > Thanks & Regards, > Navin Srinivas > > On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a><mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>> wrote: > > >> -----Original Message----- >> From: Wang, Yixue <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a><mailto:<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>> >> Sent: Thursday, June 3, 2021 6:04 PM >> To: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a><mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>>; Yang, Qiming >> <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a><mailto:<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>>> >> Cc: Zhang, Liheng <<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a><mailto:<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a>>>; Dong, Yao >> <<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a><mailto:<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a>>>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a><mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><mailto:<a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a>> >> Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary >> process >> >> Hi, Qi >> >> I've tested this patch and it works. >> >> Best Regards, >> Yixue. >> >>> -----Original Message----- >>> From: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a><mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>> >>> Sent: Monday, May 24, 2021 17:08 >>> To: Yang, Qiming <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a><mailto:<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>>> >>> Cc: Zhang, Liheng <<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a><mailto:<a href="mailto:liheng.zhang@intel.com" target="_blank">liheng.zhang@intel.com</a>>>; Wang, Yixue >>> <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a><mailto:<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>>; Dong, Yao <<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a><mailto:<a href="mailto:yao.dong@intel.com" target="_blank">yao.dong@intel.com</a>>>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a><mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; >>> Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a><mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>>; <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><mailto:<a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a>> >>> Subject: [PATCH] net/ice: fix wrong data path selection in secondary >>> process >>> >>> The flag use_avx2 and use_avx512 are defined as local variables, they >>> will not be aware by the secondary process, then wrong data path is >>> selected. Fix the issue by moving them into struct ice_adapter. >>> >>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector") >>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx") >>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") >>> Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><mailto:<a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a>> >>> >>> Reported-by: Yixue Wang <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a><mailto:<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>> >>> Signed-off-by: Qi Zhang <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a><mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>> > > Tested-by: Yixue Wang <<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a><mailto:<a href="mailto:yixue.wang@intel.com" target="_blank">yixue.wang@intel.com</a>>> > > Applied to dpdk-next-net-intel. > > Thanks > Qi </blockquote></div></div>