<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Apple Color Emoji";
panose-1:0 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 11 6 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Courier New";
color:windowtext;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New"">Hi Andrew,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New"">Changes done in this patch was accidentally removed in commit 046f1161956777e3afb13504acbe8df2ec3a383c.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New"">This was noticed later and we are trying to address this here.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New""><o:p> </o:p></span></p>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Courier New"">Thanks,<o:p></o:p></span></p>
</div>
</div>
</div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Courier New"">Pankaj</span><span style="font-size:11.0pt;font-family:"Courier New""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New""><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru><br>
<b>Date: </b>Wednesday, May 4, 2022 at 8:09 AM<br>
<b>To: </b>Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com>, Yong Wang <yongwang@vmware.com><br>
<b>Cc: </b>dev@dpdk.org <dev@dpdk.org><br>
<b>Subject: </b>Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Apple Color Emoji"">⚠</span><span style="font-size:11.0pt"> External Email<br>
<br>
On 5/3/22 07:22, Pankaj Gupta wrote:<br>
> Fix merge error in initialization for rxDataRing feature.<br>
<br>
Is it a bug fix? If so, it requires corresponding "Fixes:" tag and Cc to<br>
stable@dpdk.org in order to be backported to stable releases.<br>
<br>
><br>
> Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2.<br>
><br>
> Signed-off-by: Pankaj Gupta <pagupta@vmware.com><br>
> ---<br>
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++++<br>
> 1 file changed, 5 insertions(+)<br>
><br>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c<br>
> index 9955f121f6..6ced76ae2a 100644<br>
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c<br>
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c<br>
> @@ -876,6 +876,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)<br>
> rqd->conf.rxRingSize[1] = rxq->cmd_ring[1].size;<br>
> rqd->conf.compRingSize = rxq->comp_ring.size;<br>
><br>
> + if (VMXNET3_VERSION_GE_3(hw)) {<br>
> + rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA;<br>
> + rqd->conf.rxDataRingDescSize = rxq->data_desc_size;<br>
> + }<br>
> +<br>
> if (hw->intr.lsc_only)<br>
> rqd->conf.intrIdx = 1;<br>
> else<br>
<br>
<br>
________________________________<br>
<br>
</span><span style="font-size:11.0pt;font-family:"Apple Color Emoji"">⚠</span><span style="font-size:11.0pt"> External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.<o:p></o:p></span></p>
</div>
</div>
</body>
</html>