<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Andrew,<o:p></o:p> Please refer struct rte_eth_dev. Following assignment already preserve the order in struct rte_eth_dev<o:p></o:p> <o:p> </o:p> > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index eb65499cf2..a76796716b 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -294,6 +294,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) > eth_dev->rx_pkt_burst = &vmxnet3_recv_pkts; > eth_dev->tx_pkt_burst = &vmxnet3_xmit_pkts; > eth_dev->tx_pkt_prepare = vmxnet3_prep_pkts; > + eth_dev->rx_queue_count = vmxnet3_dev_rx_queue_count, Please, put it just after rx_pkt_burst to preserve the same order as in structure. <o:p></o:p> <o:p> </o:p> /**<o:p></o:p> * @internal<o:p></o:p> * The generic data structure associated with each Ethernet device.<o:p></o:p> *<o:p></o:p> * Pointers to burst-oriented packet receive and transmit functions are<o:p></o:p> * located at the beginning of the structure, along with the pointer to<o:p></o:p> * where all the data elements for the particular device are stored in shared<o:p></o:p> * memory. This split allows the function pointer and driver data to be per-<o:p></o:p> * process, while the actual configuration data for the device is shared.<o:p></o:p> */<o:p></o:p> struct rte_eth_dev {<o:p></o:p> eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function */<o:p></o:p> eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function */<o:p></o:p> <o:p> </o:p> /** Pointer to PMD transmit prepare function */<o:p></o:p> eth_tx_prep_t tx_pkt_prepare;<o:p></o:p> /** Get the number of used Rx descriptors */<o:p></o:p> eth_rx_queue_count_t rx_queue_count;<o:p></o:p> /** Check the status of a Rx descriptor */<o:p></o:p> eth_rx_descriptor_status_t rx_descriptor_status;<o:p></o:p> /** Check the status of a Tx descriptor */<o:p></o:p> eth_tx_descriptor_status_t tx_descriptor_status;<o:p></o:p> <o:p> </o:p> /**<o:p></o:p> * Device data that is shared between primary and secondary processes<o:p></o:p> */<o:p></o:p> struct rte_eth_dev_data *data;<o:p></o:p> void *process_private; /**< Pointer to per-process device data */<o:p></o:p> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */<o:p></o:p> struct rte_device *device; /**< Backing device */<o:p></o:p> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */<o:p></o:p> <o:p> </o:p> /** User application callbacks for NIC interrupts */<o:p></o:p> struct rte_eth_dev_cb_list link_intr_cbs;<o:p></o:p> /**<o:p></o:p> * User-supplied functions called from rx_burst to post-process<o:p></o:p> * received packets before passing them to the user<o:p></o:p> */<o:p></o:p> struct rte_eth_rxtx_callback *post_rx_burst_cbs[RTE_MAX_QUEUES_PER_PORT];<o:p></o:p> /**<o:p></o:p> * User-supplied functions called from tx_burst to pre-process<o:p></o:p> * received packets before passing them to the driver for transmission<o:p></o:p> */<o:p></o:p> struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT];<o:p></o:p> <o:p> </o:p> enum rte_eth_dev_state state; /**< Flag indicating the port state */<o:p></o:p> void *security_ctx; /**< Context for security ops */<o:p></o:p> } __rte_cache_aligned;<o:p></o:p> <o:p> </o:p> <div> <div> <div> Thanks,<o:p></o:p> </div> </div> </div> Pankaj<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Date: Wednesday, May 4, 2022 at 7:27 AM To: Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com>, Yong Wang <yongwang@vmware.com> Cc: dev@dpdk.org <dev@dpdk.org> Subject: Re: [PATCH 3/8] vmxnet3: add rx queue usage count utility<o:p></o:p> </div> <div> ⚠ External Email rx -> Rx in summary in accordance with spelling in DPDK On 5/3/22 07:22, Pankaj Gupta wrote: > Count the number of entries in the rx queue for debugging. rx -> Rx As I understand debugging is not the only purpose of the API. > > Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2 > > Signed-off-by: Pankaj Gupta <pagupta@vmware.com> > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ > drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 ++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index eb65499cf2..a76796716b 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -294,6 +294,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) > eth_dev->rx_pkt_burst = &vmxnet3_recv_pkts; > eth_dev->tx_pkt_burst = &vmxnet3_xmit_pkts; > eth_dev->tx_pkt_prepare = vmxnet3_prep_pkts; > + eth_dev->rx_queue_count = vmxnet3_dev_rx_queue_count, Please, put it just after rx_pkt_burst to preserve the same order as in structure. > pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); > > /* extra mbuf field is required to guess MSS */ [snip] ________________________________ ⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.<o:p></o:p> </div> </div> </body> </html>