<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">Hi Pankaj, On 5/4/22 23:40, Pankaj Gupta wrote: </div> <blockquote type="cite" cite="mid:BYAPR05MB56240403203DFF1047E44EF3C9C39@BYAPR05MB5624.namprd05.prod.outlook.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style>@font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face {font-family:"Apple Color Emoji"; panose-1:0 0 0 0 0 0 0 0 0 0;}@font-face {font-family:"Times New Roman \(Body CS\)"; panose-1:2 11 6 4 2 2 2 2 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; font-size:10.0pt; font-family:"Calibri",sans-serif;}span.EmailStyle19 {mso-style-type:personal-reply; font-family:"Courier New"; color:windowtext; font-weight:normal; font-style:normal;}.MsoChpDefault {mso-style-type:export-only; font-size:10.0pt;}div.WordSection1 {page:WordSection1;}</style> <div class="WordSection1"> Hi Andrew,<o:p></o:p> Packet type was not set for fragmented packets so we are trying to set it in all possible scenarios.<o:p></o:p> <o:p> </o:p> I believe TCP packets can be fragmented. </div> </blockquote> Theoretically it is possible, yes. OK, my main goal was to check that we are really talking about L3 fragmentation, not scattering on Rx and I've got the answer. Thanks, Andrew. <o:p> </o:p> <blockquote type="cite" cite="mid:BYAPR05MB56240403203DFF1047E44EF3C9C39@BYAPR05MB5624.namprd05.prod.outlook.com"> <div class="WordSection1"> <div> <div> <div> Thanks,<o:p></o:p> </div> </div> </div> Pankaj<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Andrew Rybchenko <a class="moz-txt-link-rfc2396E" href="mailto:andrew.rybchenko@oktetlabs.ru"><andrew.rybchenko@oktetlabs.ru></a> Date: Wednesday, May 4, 2022 at 8:08 AM To: Pankaj Gupta <a class="moz-txt-link-rfc2396E" href="mailto:pagupta@vmware.com"><pagupta@vmware.com></a>, Jochen Behrens <a class="moz-txt-link-rfc2396E" href="mailto:jbehrens@vmware.com"><jbehrens@vmware.com></a>, Yong Wang <a class="moz-txt-link-rfc2396E" href="mailto:yongwang@vmware.com"><yongwang@vmware.com></a> Cc: <a class="moz-txt-link-abbreviated" href="mailto:dev@dpdk.org">dev@dpdk.org</a> <a class="moz-txt-link-rfc2396E" href="mailto:dev@dpdk.org"><dev@dpdk.org></a> Subject: Re: [PATCH 7/8] vmxnet3: Set packet for fragmented packet<o:p></o:p> </div> <div> ⚠ External Email On 5/3/22 07:22, Pankaj Gupta wrote: > The packet type is set even if it is a fragmented packet I'm wondering if is really IPv4/IPv6 fragmented packets or just scattered on Rx across many Rx buffers. I'm asking since fragmented sounds weird with TCP, since TCP spec forbids fragmentation. > > Tested, using testpmd, for different hardware versions on > ESXi 7.0 Update 2. > > Signed-off-by: Pankaj Gupta <a class="moz-txt-link-rfc2396E" href="mailto:pagupta@vmware.com"><pagupta@vmware.com></a> > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c > index a6665fbf70..5e177400c0 100644 > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c > @@ -759,6 +759,23 @@ vmxnet3_rx_offload(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd, > /* Check packet type, checksum errors, etc. */ > if (rcd->cnc) { > ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; > + > + if (rcd->v4) { > + packet_type |= RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > + if (rcd->tcp) > + packet_type |= RTE_PTYPE_L4_TCP; > + else if (rcd->udp) > + packet_type |= RTE_PTYPE_L4_UDP; > + } else if (rcd->v6) { > + packet_type |= RTE_PTYPE_L3_IPV6_EXT_UNKNOWN; > + if (rcd->tcp) > + packet_type |= RTE_PTYPE_L4_TCP; > + else if (rcd->udp) > + packet_type |= RTE_PTYPE_L4_UDP; > + } else { > + packet_type |= RTE_PTYPE_UNKNOWN; > + } > + > } else { > if (rcd->v4) { > packet_type |= RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; ________________________________ ⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.<o:p></o:p> </div> </div> </blockquote> </body> </html>