<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Andrew,<o:p></o:p> New features were introduced in following two patches so I will update release_22_07.rst for these two patches.<o:p></o:p> [PATCH v6 1/9] net/vmxnet3: add version 5 support<o:p></o:p> [PATCH v6 6/9] net/vmxnet3: add version 6 support<o:p></o:p> <o:p> </o:p> Let me know if I am missing anything.<o:p></o:p> <o:p> </o:p> <div> <div> <div> Thanks,<o:p></o:p> </div> </div> </div> Pankaj<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Date: Thursday, May 19, 2022 at 1:07 AM To: Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com> Cc: dev@dpdk.org <dev@dpdk.org> Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6<o:p></o:p> </div> <div> ⚠ External Email Hi Pankaj, I did final cleanup before applying the patch series, but realized that release notes update is missing. Please, pick up my changes and amend patches which support new features with release notes update in the documentation. Everything else LGTM now. Thanks, Andrew. On 5/19/22 11:04, Andrew Rybchenko wrote: > v6 (Andrew Rybchenko): > Minor style changes in patches description > Split FW version get patch to have callbacks reorder seperately > Minor fix in FW version get patch to put callback definition, > assignment and implementation just after device info get > > v5: > Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c > User RETA instead of reta in commit message > Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c > > v4: > Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error > in initialization for rxDataRing feature" to > "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" > > v3: > adding Reviewed-by info in all the patches > > v2: > address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru > > Pankaj Gupta (9): > net/vmxnet3: add version 5 support > net/vmxnet3: implement RETA query and RETA update > net/vmxnet3: add Rx queue usage count utility > net/vmxnet3: fix ethdev callbacks init order > net/vmxnet3: report HW version on FW version get > net/vmxnet3: add version 6 support > net/vmxnet3: advertise RETA size in device info > net/vmxnet3: set packet type for fragmented packet > net/vmxnet3: fix merge error in Rx data ring initialization > > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- > 4 files changed, 388 insertions(+), 88 deletions(-) > ________________________________ ⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.<o:p></o:p> </div> </div> </body> </html>