<html data-lt-installed="true"><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div class="moz-cite-prefix">On 5/31/22 00:46, Thomas Monjalon
wrote:<br>
</div>
<blockquote type="cite" cite="mid:7384952.EvYhyI6sBW@thomas">
<pre class="moz-quote-pre" wrap="">We were waiting for a v2 of this patch.</pre>
</blockquote>
<p>Hey Thomas,</p>
<p>Thank you for the comments.</p>
<p>Yes, I'll send v2.</p>
<blockquote type="cite" cite="mid:7384952.EvYhyI6sBW@thomas">
<pre class="moz-quote-pre" wrap="">
More comments below.</pre>
</blockquote>
I'll update the patch in v2 accordingly.<br>
<blockquote type="cite" cite="mid:7384952.EvYhyI6sBW@thomas">
<pre class="moz-quote-pre" wrap="">
07/04/2022 07:30, Xiaoyu Min:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">The data-path focused flow rule management can manage flow rules in more
optimized way then tranditional one by using hits provided by
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
hits -> hints
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">application in initialization phase.
In addition to the current hints we have in port attr, more hints could
be proivded by application about it's behaviour.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
it's -> its
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">One example is how the application do with the same flow:
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
flow -> flow rule ?
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">A. create/destroy flow on same queue but query flow on different queue
or queue-less way (i.e, counter query)
B. All flow operations will be exactly on the same queue, by which PMD
could be in more optimized way then A because resource could be
isolated and access based on queue, without lock for example.
This patch add flag about above situation and could be extanded to cover
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
extended
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">more situations.
Signed-off-by: Xiaoyu Min <a class="moz-txt-link-rfc2396E" href="mailto:jackmin@nvidia.com"><jackmin@nvidia.com></a>
---
+/**
+ * The flags of rte flow port
+ */
+enum rte_flow_port_flag {
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Don't use enum for bit flags.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ /**
+ * All flow operations for one specified flow will _strictlly_ happen
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I guess you mean "for a given flow rule"
strictlly -> _strictly_
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>