<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1>Hi Ferruh,<o:p></o:p>Please see my inline responses [Damo];<o:p></o:p><o:p> </o:p>Thanks<o:p></o:p>Damo<o:p></o:p><o:p> </o:p>From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> Sent: Monday, June 20, 2022 9:47 PM To: Ferruh Yigit <ferruh.yigit@xilinx.com>; Damodharam Ammepalli <damodharam.ammepalli@broadcom.com> Cc: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>; dpdk-dev <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD<o:p></o:p><o:p> </o:p><div>Hi Damo,<o:p></o:p><div><o:p> </o:p></div><div>Could you please respond to Ferruh's question?<o:p></o:p></div><div><o:p> </o:p></div><div>Regards,<o:p></o:p></div><div>Kalesh<o:p></o:p></div></div><o:p> </o:p><div><div>On Thu, Jun 16, 2022 at 10:33 PM Ferruh Yigit <<a href="mailto:ferruh.yigit@xilinx.com">ferruh.yigit@xilinx.com</a>> wrote:<o:p></o:p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'>On 6/15/2022 3:56 PM, Kalesh A P wrote: > > From: Damodharam Ammepalli <<a href="mailto:damodharam.ammepall@broadcom.com" target="_blank">damodharam.ammepall@broadcom.com</a>> > > Currently, we fail the init/probe of pmd if eth_dev->data->nb_tx_queues > or eth_dev->data->nb_rx_queues is 0. We are removing this check. > Is there a valid usecase for Rx only or Tx only config? I assume testpmd doesn't support it, how are you testing this? [Damo]:<o:p></o:p>Yes. There is a valid use case. We are trying to address a<o:p></o:p>customer request, to deploy an application in Rxonly mode.<o:p></o:p>This is the sample testpmd command we used in our unit tests.<o:p></o:p>./build/app/dpdk-testpmd -c 0xff -n 4 --log-level="pmd.",7<o:p></o:p>--socket-mem 0,1024 -- --forward-mode=rxonly --txq=0 -i<o:p></o:p><o:p> </o:p>We can update the commit headline to indicate Rx only configuration to<o:p></o:p>prevent misunderstanding.<o:p></o:p>Please let me know and we will address accordingly.<o:p></o:p> > Fixes: daef48efe5e5 ("net/bnxt: support set MTU") > Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> > > Signed-off-by: Damodharam Ammepalli <<a href="mailto:damodharam.ammepall@broadcom.com" target="_blank">damodharam.ammepall@broadcom.com</a>> > Reviewed-by: Ajit Khaparde <<a href="mailto:ajit.khaparde@broadcom.com" target="_blank">ajit.khaparde@broadcom.com</a>> > Reviewed-by: Somnath Kotur <<a href="mailto:somnath.kotur@broadcom.com" target="_blank">somnath.kotur@broadcom.com</a>> > --- > drivers/net/bnxt/bnxt_ethdev.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 34f2149..8181e1f 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp) > sizeof(struct bnxt_ring_stats) * > bp->tx_cp_nr_rings, > 0); > - if (bp->prev_tx_ring_stats == NULL) > + if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL) > goto error; > > return 0; > @@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) > int vlan_mask = 0; > int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; > > - if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) { > - PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); > - return -EINVAL; > - } > - > if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) > PMD_DRV_LOG(ERR, > "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", > -- > 2.10.1 > <o:p></o:p></blockquote></div> <o:p></o:p><div><o:p> </o:p></div>-- <o:p></o:p><div><div>Regards,<o:p></o:p><div>Kalesh A P<o:p></o:p></div></div></div></div></body></html> This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.