<div dir="ltr">Hi Damo,<div><br></div><div>Could you please respond to Ferruh's question?</div><div><br></div><div>Regards,</div><div>Kalesh</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 16, 2022 at 10:33 PM Ferruh Yigit <<a href="mailto:ferruh.yigit@xilinx.com">ferruh.yigit@xilinx.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/15/2022 3:56 PM, Kalesh A P wrote:<br>
<br>
> <br>
> From: Damodharam Ammepalli <<a href="mailto:damodharam.ammepall@broadcom.com" target="_blank">damodharam.ammepall@broadcom.com</a>><br>
> <br>
> Currently, we fail the init/probe of pmd if eth_dev->data->nb_tx_queues<br>
> or eth_dev->data->nb_rx_queues is 0. We are removing this check.<br>
> <br>
<br>
Is there a valid usecase for Rx only or Tx only config?<br>
I assume testpmd doesn't support it, how are you testing this?<br>
<br>
> Fixes: daef48efe5e5 ("net/bnxt: support set MTU")<br>
> Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><br>
> <br>
> Signed-off-by: Damodharam Ammepalli <<a href="mailto:damodharam.ammepall@broadcom.com" target="_blank">damodharam.ammepall@broadcom.com</a>><br>
> Reviewed-by: Ajit Khaparde <<a href="mailto:ajit.khaparde@broadcom.com" target="_blank">ajit.khaparde@broadcom.com</a>><br>
> Reviewed-by: Somnath Kotur <<a href="mailto:somnath.kotur@broadcom.com" target="_blank">somnath.kotur@broadcom.com</a>><br>
> ---<br>
>   drivers/net/bnxt/bnxt_ethdev.c | 7 +------<br>
>   1 file changed, 1 insertion(+), 6 deletions(-)<br>
> <br>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c<br>
> index 34f2149..8181e1f 100644<br>
> --- a/drivers/net/bnxt/bnxt_ethdev.c<br>
> +++ b/drivers/net/bnxt/bnxt_ethdev.c<br>
> @@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp)<br>
>                                               sizeof(struct bnxt_ring_stats) *<br>
>                                               bp->tx_cp_nr_rings,<br>
>                                               0);<br>
> -       if (bp->prev_tx_ring_stats == NULL)<br>
> +       if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL)<br>
>                  goto error;<br>
> <br>
>          return 0;<br>
> @@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)<br>
>          int vlan_mask = 0;<br>
>          int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;<br>
> <br>
> -       if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {<br>
> -               PMD_DRV_LOG(ERR, "Queues are not configured yet!\n");<br>
> -               return -EINVAL;<br>
> -       }<br>
> -<br>
>          if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)<br>
>                  PMD_DRV_LOG(ERR,<br>
>                              "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",<br>
> --<br>
> 2.10.1<br>
> <br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">Regards,<div>Kalesh A P</div></div></div>