<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 8/9/2022 2:15 AM, Dmitry Kozlyuk
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20220809121548.00a18082@sovereign">
<pre class="moz-quote-pre" wrap="">2022-08-08 17:33 (UTC-0700), Kadam, Pallavi:
[...]
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi Pallavi,
In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT`
because only the first BAR slot of a 64-bit BAR contains flags.
The current code has a state to track (curr_bar, prev_bar),
and the fix is complicating it even more without solving the root cause.
I suggest a simpler fix (not tested!)
that eliminates both the incorrectness and the state to maintain:
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Thank you. This change works for us.
Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Please send v2.
You can include my Signed-off-by.
You might also update the commit message and capitalize "BAR" in the title.</pre>
</blockquote>
<pre>Thanks, Dmitry. Have sent v2.</pre>
<blockquote type="cite" cite="mid:20220809121548.00a18082@sovereign">
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
</html>