<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hi, David, Thanks a lot for your helpful reply. <div class="moz-cite-prefix">On Fri, Sep 30, 2022 at 22:20, David Marchand wrote: </div> <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">On Fri, Sep 30, 2022 at 12:05 PM zhoumin <a class="moz-txt-link-rfc2396E" href="mailto:zhoumin@loongson.cn"><zhoumin@loongson.cn></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">On Fri, Sep 30, 2022 at 16:13, David Marchand wrote: </pre> <blockquote type="cite"> <pre wrap="">On Fri, Sep 30, 2022 at 10:02 AM Min Zhou <a class="moz-txt-link-rfc2396E" href="mailto:zhoumin@loongson.cn"><zhoumin@loongson.cn></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">The online documents of LoongArch architecture are here: <a class="moz-txt-link-freetext" href="https://loongson.github.io/LoongArch-Documentation/README-EN.html">https://loongson.github.io/LoongArch-Documentation/README-EN.html</a> The latest build tools for LoongArch (binary) can be downloaded from: <a class="moz-txt-link-freetext" href="https://github.com/loongson/build-tools">https://github.com/loongson/build-tools</a> </pre> </blockquote> <pre wrap="">Could you confirm which sources have been used to generate it? and instructions to compile it? </pre> </blockquote> <pre wrap="">Only the cross compiler [1] is required. The instructions can be found in the new added file cross_build_dpdk_for_loongarch.rst. I had added the CI job for cross compiling DPDK for LoongArch in patch v7 7/7. The CI job can run successfully if without the GCC warning caused by vhost. </pre> </blockquote> <pre wrap="">- Sorry, but those instructions are not useful. Is this architecture support in upstream gcc not functional? Maybe I missed the information.. I spent some time at the different links in the docs and in github, but I always end up with a set of headers, or binaries, and no reference to the exact sources that were used. I have limited trust in binaries uploaded somewhere in github. I don't want to spend more time on this. What I ask for, is clear instructions how to get the toolchain sources, and how to generate this toolchain. </pre> </blockquote> I'm Sorry, I misunderstood the 'instructions' you said. The process of making the toolchain is a little complicated. So I made a script used to generate the toolchain from source codes. The content of the script is as follows: #!/bin/bash # Prepare the working directories export SYSDIR=/tmp/la_cross_tools mkdir -pv ${SYSDIR} mkdir -pv ${SYSDIR}/downloads mkdir -pv ${SYSDIR}/build install -dv ${SYSDIR}/cross-tools install -dv ${SYSDIR}/sysroot set +h umask 022 # Set the environment variables to be used next export BUILDDIR="${SYSDIR}/build" export DOWNLOADDIR="${SYSDIR}/downloads" export LC_ALL=POSIX export CROSS_HOST="$(echo $MACHTYPE | sed "s/$(echo $MACHTYPE | cut -d- -f2)/cross/")" export CROSS_TARGET="loongarch64-unknown-linux-gnu" export MABI="lp64d" export BUILD64="-mabi=lp64d" export PATH=${SYSDIR}/cross-tools/bin:/bin:/usr/bin export JOBS=-j8 unset CFLAGS unset CXXFLAGS # Download the source code archives pushd $DOWNLOADDIR wget <a class="moz-txt-link-freetext" href="https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-5.19.tar.gz">https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-5.19.tar.gz</a> wget <a class="moz-txt-link-freetext" href="https://ftp.gnu.org/gnu/gmp/gmp-6.2.1.tar.xz">https://ftp.gnu.org/gnu/gmp/gmp-6.2.1.tar.xz</a> wget <a class="moz-txt-link-freetext" href="https://www.mpfr.org/mpfr-4.1.0/mpfr-4.1.0.tar.xz">https://www.mpfr.org/mpfr-4.1.0/mpfr-4.1.0.tar.xz</a> wget <a class="moz-txt-link-freetext" href="https://ftp.gnu.org/gnu/mpc/mpc-1.2.1.tar.gz">https://ftp.gnu.org/gnu/mpc/mpc-1.2.1.tar.gz</a> wget <a class="moz-txt-link-freetext" href="https://ftp.gnu.org/gnu/libc/glibc-2.36.tar.xz">https://ftp.gnu.org/gnu/libc/glibc-2.36.tar.xz</a> popd # Make and install the linux header files tar xvf ${DOWNLOADDIR}/linux-5.19.tar.gz -C ${BUILDDIR} pushd ${BUILDDIR}/linux-5.19 make mrproper make ARCH=loongarch INSTALL_HDR_PATH=dest headers_install find dest/include -name '.*' -delete mkdir -pv ${SYSDIR}/sysroot/usr/include cp -rv dest/include/* ${SYSDIR}/sysroot/usr/include popd # Prepare the binutils source code git clone git://sourceware.org/git/binutils-gdb.git --depth 1 pushd binutils-gdb git archive --format=tar.gz --prefix=binutils-2.38/ --output ../binutils-2.38.tar.gz "master" popd mv binutils-2.38.tar.gz ${DOWNLOADDIR} # Make and install the binutils files tar xvf ${DOWNLOADDIR}/binutils-2.38.tar.gz -C ${BUILDDIR} pushd ${BUILDDIR}/binutils-2.38 rm -rf gdb* libdecnumber readline sim mkdir tools-build pushd tools-build CC=gcc AR=ar AS=as \ ../configure --prefix=${SYSDIR}/cross-tools --build=${CROSS_HOST} --host=${CROSS_HOST} \ --target=${CROSS_TARGET} --with-sysroot=${SYSDIR}/sysroot --disable-nls \ --disable-static --disable-werror --enable-64-bit-bfd make configure-host ${JOBS} make ${JOBS} make install-strip cp -v ../include/libiberty.h ${SYSDIR}/sysroot/usr/include popd popd # Make and install the gmp files used by GCC tar xvf ${DOWNLOADDIR}/gmp-6.2.1.tar.xz -C ${BUILDDIR} pushd ${BUILDDIR}/gmp-6.2.1 ./configure --prefix=${SYSDIR}/cross-tools --enable-cxx --disable-static make ${JOBS} make install popd # Make and install the mpfr files used by GCC tar xvf ${DOWNLOADDIR}/mpfr-4.1.0.tar.xz -C ${BUILDDIR} pushd ${BUILDDIR}/mpfr-4.1.0 ./configure --prefix=${SYSDIR}/cross-tools --disable-static --with-gmp=${SYSDIR}/cross-tools make ${JOBS} make install popd # Make and install the mpc files used by GCC tar xvf ${DOWNLOADDIR}/mpc-1.2.1.tar.gz -C ${BUILDDIR} pushd ${BUILDDIR}/mpc-1.2.1 ./configure --prefix=${SYSDIR}/cross-tools --disable-static --with-gmp=${SYSDIR}/cross-tools make ${JOBS} make install popd # Prepare the gcc source code git clone git://sourceware.org/git/gcc.git --depth 1 pushd gcc git archive --format=tar.gz --prefix=gcc-13.0.0/ --output ../gcc-13.0.0.tar.gz "master" popd mv gcc-13.0.0.tar.gz ${DOWNLOADDIR} # Make and install the simplified GCC files tar xvf ${DOWNLOADDIR}/gcc-13.0.0.tar.gz -C ${BUILDDIR} pushd ${BUILDDIR}/gcc-13.0.0 mkdir tools-build pushd tools-build AR=ar LDFLAGS="-Wl,-rpath,${SYSDIR}/cross-tools/lib" \ ../configure --prefix=${SYSDIR}/cross-tools --build=${CROSS_HOST} --host=${CROSS_HOST} \ --target=${CROSS_TARGET} --disable-nls \ --with-mpfr=${SYSDIR}/cross-tools --with-gmp=${SYSDIR}/cross-tools \ --with-mpc=${SYSDIR}/cross-tools \ --with-newlib --disable-shared --with-sysroot=${SYSDIR}/sysroot \ --disable-decimal-float --disable-libgomp --disable-libitm \ --disable-libsanitizer --disable-libquadmath --disable-threads \ --disable-target-zlib --with-system-zlib --enable-checking=release \ --enable-default-pie \ --enable-languages=c make all-gcc all-target-libgcc ${JOBS} make install-strip-gcc install-strip-target-libgcc popd popd # Make and install the glibc files tar xvf ${DOWNLOADDIR}/glibc-2.36.tar.xz -C ${BUILDDIR} pushd ${BUILDDIR}/glibc-2.36 sed -i <a class="moz-txt-link-rfc2396E" href="mailto:s@5.15.0@4.15.0@g">"s@5.15.0@4.15.0@g"</a> sysdeps/unix/sysv/linux/loongarch/configure{,.ac} mkdir -v build-64 pushd build-64 BUILD_CC="gcc" CC="${CROSS_TARGET}-gcc ${BUILD64}" \ CXX="${CROSS_TARGET}-gcc ${BUILD64}" \ AR="${CROSS_TARGET}-ar" RANLIB="${CROSS_TARGET}-ranlib" \ ../configure --prefix=/usr --host=${CROSS_TARGET} --build=${CROSS_HOST} \ --libdir=/usr/lib64 --libexecdir=/usr/lib64/glibc \ --with-binutils=${SYSDIR}/cross-tools/bin \ --with-headers=${SYSDIR}/sysroot/usr/include \ --enable-stack-protector=strong --enable-add-ons \ --disable-werror libc_cv_slibdir=/usr/lib64 \ --enable-kernel=4.15 make ${JOBS} make DESTDIR=${SYSDIR}/sysroot install cp -v ../nscd/nscd.conf ${SYSDIR}/sysroot/etc/nscd.conf mkdir -pv ${SYSDIR}/sysroot/var/cache/nscd install -v -Dm644 ../nscd/nscd.tmpfiles \ ${SYSDIR}/sysroot/usr/lib/tmpfiles.d/nscd.conf install -v -Dm644 ../nscd/nscd.service \ ${SYSDIR}/sysroot/usr/lib/systemd/system/nscd.service popd mkdir -v build-locale pushd build-locale ../configure --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/lib64/glibc \ --enable-stack-protector=strong --enable-add-ons \ --disable-werror libc_cv_slibdir=/usr/lib64 make ${JOBS} make DESTDIR=${SYSDIR}/sysroot localedata/install-locales popd popd # Make and install the complete GCC files tar xvf ${DOWNLOADDIR}/gcc-13.0.0.tar.gz -C ${BUILDDIR} pushd ${BUILDDIR}/gcc-13.0.0 mkdir tools-build-all pushd tools-build-all AR=ar LDFLAGS="-Wl,-rpath,${SYSDIR}/cross-tools/lib" \ ../configure --prefix=${SYSDIR}/cross-tools --build=${CROSS_HOST} \ --host=${CROSS_HOST} --target=${CROSS_TARGET} \ --with-sysroot=${SYSDIR}/sysroot --with-mpfr=${SYSDIR}/cross-tools \ --with-gmp=${SYSDIR}/cross-tools --with-mpc=${SYSDIR}/cross-tools \ --enable-__cxa_atexit --enable-threads=posix --with-system-zlib \ --enable-libstdcxx-time --enable-checking=release \ --enable-default-pie \ --enable-languages=c,c++,fortran,objc,obj-c++,lto make ${JOBS} make install-strip popd popd I have tested the script on an x86 machine running CentOS 8 system. I successfully used the toolchain generated by this script to cross compiling DPDK for LoongArch. This script may take one hour to complete, which depends on the speed of network and the performance of machine used. This script requires at least 15G of disk space when running. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">- About the vhost compilation issue, a fix in the same area of the code is in progress. It will take some time to get the fix. I will postpone merging the last patch until the vhost fix is ready. (I am rather confident all of this will be resolved by the time 22.11 is released). </pre> </blockquote> Thank you for your concern and efforts on this issue. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap=""> </pre> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <pre wrap="">v7: - rebase the patchset on the main repository - add errno.h to rte_power_intrinsics.c according with commit 72b452c5f259 </pre> </blockquote> <pre wrap="">Thanks, I will look at this last revision. There is still one aspect that is unclear to me. How will the DPDK community make sure changes won't break this architecture? (I mean, runtime checks, not only compilation) IOW, what do you plan to hook to our CI to test patches submitted to the mailing list? </pre> </blockquote> <pre wrap="">We can send our machine to UNH lab, but it may take a long time. GHA seems to be a good choice. However, I found that the codes of CI runner of GHA [2] are arch-specific. So the CI runner currently cannot run on LoongArch machine. </pre> </blockquote> <pre wrap="">I see. The better solution is probably to go with "your" own CI so that that LoongArch has runtime non regression (functional and performance) tests. See below. </pre> </blockquote> Yes, we had spent some time building our own CI system and made the CI system working internally. Our CI system based on Jenkins and DTS. Every time we submit patch to our internal DPDK repository, the Jenkins will be triggered to call DTS for testing the patch. But we have only run less than 100 unit tests currently. More test cases will be added later. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap=""> </pre> <blockquote type="cite"> <pre wrap="">Are there other CI clients which are not arch-specific and can be used for DPDK? We can provide machines accessible by the public network. These machines run Loongnix-server system which was built based on the source rpms of CentOS 8. We can deploy DPDK CI client on these machines. </pre> </blockquote> <pre wrap="">There is no "DPDK CI client" per se. The DPDK project has a distributed CI made of at least 3 CI entities. Those CI test patches and post reports via mail: the ovsrobot, Intel CI and UNH lab. A CI retrieves patches from patchwork, a set of scripts is available in <a class="moz-txt-link-freetext" href="https://git.dpdk.org/tools/dpdk-ci/">https://git.dpdk.org/tools/dpdk-ci/</a> (especially the poll-pw script). </pre> </blockquote> This information is really very useful. Please forgive me for not taking the time to study dpdk-ci. It sounds that dpdk-ci can help us to test patches submitted to the mailing list for LoongArch. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">Then the way the patches are tested is something each CI handles on its side: - the ovsrobot creates a branch per series under the ovsrobot/dpdk github repository, and let GitHub action run (this is how your current series has been tested in GHA), - Intel CI have their own tool for which I have little detail, - UNH lab have their infrastructure too, using some Jenkins iirc. They provide a dashboard for reports <a class="moz-txt-link-freetext" href="https://lab.dpdk.org/results/dashboard/">https://lab.dpdk.org/results/dashboard/</a> and to get all details and logs. The common point is that, at the end of testing a series, a test report is sent to the (sender-restricted) test-report@ mailing list. </pre> </blockquote> This process doesn't seem very complicated. We can build a CI system to retrieve patches from patchwork by dpdk-ci and compile, test them on Loongnix system. After completing those jobs, we will generate the test report and send it to the test-report@ mailing list. But my concern is which set of test cases we need to run. Besides, can patchwork gather the test reports we sent and show them on the patch details web page? <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">Those reports could be done per patch, but given the amount of patches on the dev@ mailing list, the consensus is to test the whole series and report back against the last patch of a series. All of this is gathered by patchwork (the details of how it is done are not 100% clear to me, maybe Ali can confirm later if a modification is required). </pre> </blockquote> Thank you for your consideration. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">If you look at your v7 series, you will see: <a class="moz-txt-link-freetext" href="https://patchwork.dpdk.org/project/dpdk/list/?series=24929&state=%2A&archive=both">https://patchwork.dpdk.org/project/dpdk/list/?series=24929&state=%2A&archive=both</a> - ovsrobot: ci/github-robot link <a class="moz-txt-link-freetext" href="http://mails.dpdk.org/archives/test-report/2022-September/310836.html">http://mails.dpdk.org/archives/test-report/2022-September/310836.html</a> - Intel CI: ci/Intel-* links, for example on the compilation test <a class="moz-txt-link-freetext" href="http://mails.dpdk.org/archives/test-report/2022-September/310822.html">http://mails.dpdk.org/archives/test-report/2022-September/310822.html</a> - UNH lab: all ci/iol-* links, for example on the compilation test <a class="moz-txt-link-freetext" href="http://mails.dpdk.org/archives/test-report/2022-September/310834.html">http://mails.dpdk.org/archives/test-report/2022-September/310834.html</a> So what LoongSoon could do is setup some Loongnix systems with a similar infrastructure and provide (native?) compilation and runtime test reports. </pre> </blockquote> Yes, we will build the CI system talked above on Loongnix systems to provide compilation and runtime test reports for DPDK on LoongArch machine. But It will take some time to set up this system and make it run stably. We will get this done as soon as possible. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap="">I Cc'd a few people involved in all this. And there is the ci@ mailing list where all CI people can discuss. </pre> </blockquote> Thanks a lot for all your help. <blockquote type="cite" cite="mid:CAJFAV8wGOqWjuW1HZfWmtUMt3w3J=94ZZpF3VZRqk9zM9C_O4A@mail.gmail.com"> <pre wrap=""> </pre> </blockquote> -- Thanks, Min Zhou </body> </html>