<div dir="ltr"><br><div class="gmail_quote"><div dir="ltr"><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 11, 2022 at 1:03 AM David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran<br>
<<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> wrote:<br>
><br>
> From: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>><br>
><br>
> When GRO packets are merged the packet length is used while<br>
> merging the adjacent packets. If the padded bytes are accounted<br>
> we would end up acking unsent TCP segments.<br>
><br>
> Signed-off-by: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>><br>
> v1:<br>
> If there is padding to the ethernet frame cases where timestamp is disabled<br>
> the packet length should be validated with the total ip length as packet length<br>
> is used in the GRO merging logic<br>
<br>
Please, can you test with current main branch?<br>
We recently merged a fix:<br>
<a href="https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403" rel="noreferrer" target="_blank">https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403</a><br>
<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thanks, David. I did look at the patch. This would fix the problem, but lets say for a case of an ACK packet where TCP data length would be zero and if the packet contains the padded bytes, this check should be done before the follwing check and not after this. <a class="gmail_plusreply" id="m_-430350325631565276plusReplyChip-0" href="mailto:jiayu.hu@intel.com" target="_blank">@Hu, Jiayu</a> <a class="gmail_plusreply" id="m_-430350325631565276plusReplyChip-2" href="mailto:jun.qiu@jaguarmicro.com" target="_blank">@Jun Qiu</a> please let me know your thoughts. <br></blockquote></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">/*<br> * Don't process the packet whose payload length is less than or<br> * equal to 0.<br> */<br> tcp_dl = pkt->pkt_len - hdr_len;<br> if (tcp_dl <= 0)<br> return -1; <br></blockquote></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-- <br>
David Marchand<br>
<br>
</blockquote></div></div>
</div></div>