<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> Yes, It's better to do it before the tcp_dl check.<o:p></o:p> <o:p> </o:p> <div style="mso-element:para-border-div;border:none;border-left:solid #6CE26C 2.25pt;padding:0cm 0cm 0cm 0cm;background:white;margin-left:18.0pt;margin-right:0cm"> <ol start="1" type="1"> <li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm"> /* trim the tail padding bytes */ <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> ip_tlen = rte_be_to_cpu_16(ipv4_hdr->total_length); <o:p></o:p></li><li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> if (pkt->pkt_len > (uint32_t)(ip_tlen + pkt->l2_len)) <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> rte_pktmbuf_trim(pkt, pkt->pkt_len - ip_tlen - pkt->l2_len); <o:p></o:p></li><li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> /* <o:p></o:p></li><li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> * Don't process the packet whose payload length is less than or <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> * equal to 0. <o:p></o:p></li><li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> */ <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> tcp_dl = pkt->pkt_len - hdr_len; <o:p></o:p></li><li class="alt" style="color:#5C5C5C;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:white;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> if (tcp_dl <= 0) <o:p></o:p></li><li class="MsoNormal" style="color:#5C5C5C;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:-18.0pt;line-height:10.5pt;mso-list:l0 level1 lfo1;background:#F8F8F8;border:none;padding:0cm;box-sizing: border-box;border-image: initial;list-style-image:initial;list-style-type:decimal-leading-zero;list-style-position:outside"> return -1; <o:p></o:p></li></ol> </div> From: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com> Sent: Tuesday, October 11, 2022 1:48 PM To: dev@dpdk.org; David Marchand <david.marchand@redhat.com>; Hu, Jiayu <jiayu.hu@intel.com>; Jun Qiu <jun.qiu@jaguarmicro.com> Subject: Fwd: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame<o:p></o:p> <o:p> </o:p> <div> <o:p> </o:p> <div> <div> <o:p> </o:p> <div> <div> On Tue, Oct 11, 2022 at 1:03 AM David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>> wrote:<o:p></o:p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> wrote: > > From: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> > > When GRO packets are merged the packet length is used while > merging the adjacent packets. If the padded bytes are accounted > we would end up acking unsent TCP segments. > > Signed-off-by: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> > v1: > If there is padding to the ethernet frame cases where timestamp is disabled > the packet length should be validated with the total ip length as packet length > is used in the GRO merging logic Please, can you test with current main branch? We recently merged a fix: <a href="https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403" target="_blank">https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403</a><o:p></o:p> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> Thanks, David. I did look at the patch. This would fix the problem, but lets say for a case of an ACK packet where TCP data length would be zero and if the packet contains the padded bytes, this check should be done before the follwing check and not after this. <a href="mailto:jiayu.hu@intel.com" target="_blank">@Hu, Jiayu</a> <a href="mailto:jun.qiu@jaguarmicro.com" target="_blank"> @Jun Qiu</a> please let me know your thoughts. <o:p></o:p> </blockquote> </blockquote> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> /* * Don't process the packet whose payload length is less than or * equal to 0. */ tcp_dl = pkt->pkt_len - hdr_len; if (tcp_dl <= 0) return -1; <o:p></o:p> </blockquote> </blockquote> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> -- David Marchand<o:p></o:p> </blockquote> </div> </div> </div> </div> </div> </body> </html>