<div dir="ltr"><div>Hi Jiayu,</div><div> </div><div>Please find the patch <a href="http://patches.dpdk.org/project/dpdk/patch/20221016144305.19249-1-kumaraparmesh92@gmail.com/">http://patches.dpdk.org/project/dpdk/patch/20221016144305.19249-1-kumaraparmesh92@gmail.com/</a> </div><div> </div><div>I did reply with the above message ID but for some reason a new patch series was created. Not sure what was the mistake that I made. Should the commit message be the same for the series ? </div><div> </div><div>Thanks,</div><div>Kumara. </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Oct 16, 2022 at 12:31 PM Hu, Jiayu <<a href="mailto:jiayu.hu@intel.com">jiayu.hu@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-5317273817241004428"> <div style="overflow-wrap: break-word;" lang="EN-US"> <div class="m_-5317273817241004428WordSection1"> Hi Kumara, Agree. We need to trim padding bytes first, then do the length check. Thanks, Jiayu <div style="border-color:currentcolor currentcolor currentcolor blue;border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0in 0in 0in 4pt"> <div> <div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0in 0in"> From: Jun Qiu <<a href="mailto:jun.qiu@jaguarmicro.com" target="_blank">jun.qiu@jaguarmicro.com</a>> Sent: Wednesday, October 12, 2022 9:35 AM To: kumaraparameshwaran rathinavel <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>; David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>>; Hu, Jiayu <<a href="mailto:jiayu.hu@intel.com" target="_blank">jiayu.hu@intel.com</a>> Subject: RE: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame </div> </div> Yes, It's better to do it before the tcp_dl check. <div style="border-color:currentcolor currentcolor currentcolor rgb(108,226,108);border-style:none none none solid;border-width:medium medium medium 2.25pt;padding:0in"> <ol type="1" start="1"> <li class="m_-5317273817241004428alt" style="color:rgb(92,92,92);line-height:10.5pt;background:white"> /* trim the tail padding bytes */ </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> ip_tlen = rte_be_to_cpu_16(ipv4_hdr->total_length); </li><li class="m_-5317273817241004428alt" style="line-height:10.5pt;background:white;box-sizing:border-box;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> if (pkt->pkt_len > (uint32_t)(ip_tlen + pkt->l2_len)) </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> rte_pktmbuf_trim(pkt, pkt->pkt_len - ip_tlen - pkt->l2_len); </li><li class="m_-5317273817241004428alt" style="line-height:10.5pt;background:white;box-sizing:border-box;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> /* </li><li class="m_-5317273817241004428alt" style="line-height:10.5pt;background:white;box-sizing:border-box;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> * Don't process the packet whose payload length is less than or </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> * equal to 0. </li><li class="m_-5317273817241004428alt" style="line-height:10.5pt;background:white;box-sizing:border-box;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> */ </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> tcp_dl = pkt->pkt_len - hdr_len; </li><li class="m_-5317273817241004428alt" style="line-height:10.5pt;background:white;box-sizing:border-box;list-style-type:decimal-leading-zero;color:inherit;list-style-position:outside"> if (tcp_dl <= 0) </li><li class="MsoNormal" style="color:rgb(92,92,92);line-height:10.5pt;background:rgb(248,248,248);box-sizing:border-box;list-style-type:decimal-leading-zero;list-style-position:outside"> return -1; </li></ol> </div> From: kumaraparameshwaran rathinavel <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> Sent: Tuesday, October 11, 2022 1:48 PM To: <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>; David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>>; Hu, Jiayu <<a href="mailto:jiayu.hu@intel.com" target="_blank">jiayu.hu@intel.com</a>>; Jun Qiu <<a href="mailto:jun.qiu@jaguarmicro.com" target="_blank">jun.qiu@jaguarmicro.com</a>> Subject: Fwd: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame <div> <div> <div> <div> <div> On Tue, Oct 11, 2022 at 1:03 AM David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>> wrote: </div> <blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt"> On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> wrote: > > From: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> > > When GRO packets are merged the packet length is used while > merging the adjacent packets. If the padded bytes are accounted > we would end up acking unsent TCP segments. > > Signed-off-by: Kumara Parameshwaran <<a href="mailto:kumaraparamesh92@gmail.com" target="_blank">kumaraparamesh92@gmail.com</a>> > v1: > If there is padding to the ethernet frame cases where timestamp is disabled > the packet length should be validated with the total ip length as packet length > is used in the GRO merging logic Please, can you test with current main branch? We recently merged a fix: <a href="https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403" target="_blank">https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403</a> <blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt"> Thanks, David. I did look at the patch. This would fix the problem, but lets say for a case of an ACK packet where TCP data length would be zero and if the packet contains the padded bytes, this check should be done before the follwing check and not after this. <a href="mailto:jiayu.hu@intel.com" target="_blank"> @Hu, Jiayu</a> <a href="mailto:jun.qiu@jaguarmicro.com" target="_blank">@Jun Qiu</a> please let me know your thoughts. </blockquote> </blockquote> <blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt"> <blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt"> /* * Don't process the packet whose payload length is less than or * equal to 0. */ tcp_dl = pkt->pkt_len - hdr_len; if (tcp_dl <= 0) return -1; </blockquote> </blockquote> <blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt"> -- David Marchand </blockquote> </div> </div> </div> </div> </div> </div> </div> </div></blockquote></div>