<div dir="ltr"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 8, 2022 at 9:37 AM Honnappa Nagarahalli <<a href="mailto:Honnappa.Nagarahalli@arm.com" target="_blank">Honnappa.Nagarahalli@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+ Lijuan, Owen, Juraj<br>
<br>
> -----Original Message-----<br>
> From: Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>><br>
> Sent: Tuesday, November 8, 2022 7:02 AM<br>
> To: Aman Singh <<a href="mailto:aman.deep.singh@intel.com" target="_blank">aman.deep.singh@intel.com</a>>; Yuying Zhang<br>
> <<a href="mailto:yuying.zhang@intel.com" target="_blank">yuying.zhang@intel.com</a>><br>
> Cc: <a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>; <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a><br>
> Subject: testpmd logging<br>
> <br>
> Hello,<br>
> <br>
> I see testpmd is doing log with EAL entity. Example:<br>
> RTE_LOG(ERR, EAL, "The device: %s has been added!\n"<br>
> We could also discuss the log level.<br>
> <br>
> Please can we work on replacing these logs?<br></blockquote><div><br></div><div>If we want to revisit logging in testpmd, even though I know I'm invoking a case of second system syndrome here, I would love to see some form of structured logging output. Even just writing out records to a CSV file with proper escaping would work great, or doing a json object per log record as a backup. JSON might be easier since libjansson is already in DPDK, and we could disable the json logging flag if libjansson was not present at compile time. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
DTS uses some of the logs from testpmd to validate the results. I am not sure what all logs are used.</blockquote><div> </div><div>The old version of dts (the one with its own repository) is fairly tightly bound to testpmd's logging. </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> We need to choose how to log (printf or registered log entity) and be<br>
> consistent.<br>
> What do you think?<br></blockquote><div><br></div><div>Registered log entries are much better in my opinion since they provide a more machine-friendly format and DTS has to parse testpmd output.</div></div></div>