<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;" bgcolor="#fcfcfc" text="#232627" link="#2980b9" vlink="#232627"><div>On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>21/11/2022 21:40, </pre><a href="mailto:okaya@kernel.org"><pre>okaya@kernel.org</pre></a><pre>:</pre><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>--- a/drivers/net/tap/rte_eth_tap.c</pre><pre>+++ b/drivers/net/tap/rte_eth_tap.c</pre><pre>@@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)</pre><pre> struct rte_eth_dev *eth_dev;</pre><pre> </pre><pre> name = rte_vdev_device_name(dev);</pre><pre>+ if (!name) {</pre></blockquote><pre><br></pre><pre>Please it is preferred to check against NULL,</pre><pre>because name is not a boolean, thanks.</pre><pre>I know it's longer but it is more explicit.</pre></blockquote><div><br></div><div>Sure, I can do that. Getting used to dpdk coding style. I wasn't sure</div><div>what to do with braces on single line too. At least, I got a warning on</div><div>that too.</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre><br></pre><pre>Thanks for the fixes in this series.</pre><pre><br></pre><pre><br></pre></blockquote><pre><br></pre><pre>Cheers</pre></body></html>