<div dir="ltr">Thomas - thanks for the response. We will proceed with making the necessary changes for using v22.11.1.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 8, 2022 at 8:22 AM Thomas Monjalon <<a href="mailto:thomas@monjalon.net">thomas@monjalon.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I'm sorry Patrick that it gives you more work.<br>
Your proposals below don't look possible because a tag is something fixed forever.<br>
We had an ABI issue in the initial tag so we cannot use the tag v22.11 as planned.<br>
I don't see how we can better plan except having more tests on release candidates.<br>
<br>
<br>
07/12/2022 19:00, Patrick Robb:<br>
> Hello,<br>
> <br>
> Community Lab team members are wondering whether it is possible to bump<br>
> v22.11 to include at least this patch. We have an existing codebase which<br>
> relies on a vXX.XX scheme for producing ABI references. We parse that out<br>
> at different places in our code, so fixing this to handle vXX.XX.X will<br>
> require some changes on our end. We can do that, but it puts the timeline<br>
> on turning on ABI testing at the community lab back some. A v22.11 tagged<br>
> release with this patch would allow for us to turn on ABI testing<br>
> immediately. There was also a suggestion that having the "base" tag (like<br>
> the simple v22.11) point to the latest revision is a more standard version<br>
> naming approach and may be more intuitive than what is being used currently.<br>
> <br>
> If that is not possible, we will update our code to be able to refer to a<br>
> vXX.XX.X tag for producing the ABI reference. If we adopt this approach, we<br>
> would like to request that with future releases, a "vXX.XX.0" tag could<br>
> always be made available for us to produce ABI references from. That way,<br>
> we can prepare for turning on ABI testing knowing beforehand the tag name<br>
> we will be using.<br>
> <br>
> On Tue, Dec 6, 2022 at 7:25 AM Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>> wrote:<br>
> <br>
> > On 12/6/2022 10:18 AM, David Marchand wrote:<br>
> > > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>><br>
> > wrote:<br>
> > >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote:<br>
> > >>> 05/12/2022 14:47, Akhil Goyal:<br>
> > >>>> But adding a tag on same repo is more convenient from developer point<br>
> > of view.<br>
> > >>>> However, it is my personal view, others may differ.<br>
> > >>><br>
> > >>> From developer point of view, you should use<br>
> > devtools/test-meson-builds.sh<br>
> > >>> which does the "git clone" for you.<br>
> > >>><br>
> > >>> This is what I have in ~/.config/dpdk/devel.config<br>
> > >>> export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref<br>
> > >>> export DPDK_ABI_REF_VERSION=v22.11.1<br>
> > >>><br>
> > >><br>
> > >> Does it help to update 'test-meson-builds.sh' to use an environment<br>
> > >> variable to select which repo to clone?<br>
> > >> If so, I can send a patch for it.<br>
> > ><br>
> > > I was wondering too...<br>
> > > I would expect most maintainers have the stable repo in their config<br>
> > > but it would not hurt to handle the case when they don't for others.<br>
> > ><br>
> > > +1<br>
> ><br>
> > Sent following if it helps:<br>
> > <a href="https://patches.dpdk.org/project/dpdk/list/?series=26015" rel="noreferrer" target="_blank">https://patches.dpdk.org/project/dpdk/list/?series=26015</a><br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="font-size:13.3333px;white-space:pre-wrap">Patrick Robb</span></font></p><p style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical Service Manager</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">UNH InterOperability Laboratory</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">21 Madbury Rd, Suite 100, Durham, NH 03824</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(17,85,204);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://www.iol.unh.edu/" style="color:rgb(17,85,204)" target="_blank">www.iol.unh.edu</a></span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><br></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(51,51,51);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><img src="https://lh4.googleusercontent.com/7sTY8VswXadak_YT0J13osh5ockNVRX2BuYaRsKoTTpkpilBokA0WlocYHLB4q7XUgXNHka6-ns47S8R_am0sOt7MYQQ1ILQ3S-P5aezsrjp3-IsJMmMrErHWmTARNgZhpAx06n2" width="150" height="37" style="border: none;"></span></p></div></div>