<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size: 11pt;"><b>From:</b> Zhang, Qi Z <qi.z.zhang@intel.com><br>
<b>Sent:</b> 17 January 2023 07:24<br>
<b>To:</b> Vipin P R <vipinp@vmware.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com><br>
<b>Cc:</b> dev@dpdk.org <dev@dpdk.org>; stable@dpdk.org <stable@dpdk.org><br>
<b>Subject:</b> RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText elementToProof">!! External Email<br>
<br>
> -----Original Message-----<br>
> From: Vipin P R <vipinp@vmware.com><br>
> Sent: Friday, January 13, 2023 9:19 PM<br>
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com><br>
> Cc: dev@dpdk.org; Vipin P R <vipinp@vmware.com>; stable@dpdk.org<br>
> Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address<br>
><br>
> In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and<br>
> VIRTCHNL_OP_ADD_ETH_ADDR are unsupported.<br>
> i40evf_execute_vf_cmd is invoked with these operations as part of<br>
> i40evf_set_mc_addr_list()<br>
><br>
> The cases are not handled in i40evf_execute_vf_cmd() thus hitting the<br>
> default case.<br>
> There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms<br>
> in iavf).<br>
> This results in a needless delay of 2s in the init phase for each VNIC.<br>
><br>
<br>
<blockquote itemscope="" itemtype="https://schemas.microsoft.com/QuotedText" style="border-left: 3px solid rgb(200, 200, 200); border-top-color: rgb(200, 200, 200); border-right-color: rgb(200, 200, 200); border-bottom-color: rgb(200, 200, 200); padding-left: 1ex; margin-left: 0.8ex;">
Sorry I didn't get this, why this is related with i40evf? I40evf PMD has been replaced by iavf PMD.<br>
The iavf PMD works with both i40e and ice, does this will break ice's usage?<br>
</blockquote>
<div class="PlainText elementToProof"><br>
</div>
</div>
<div class="PlainText elementToProof">Hi, this is problem was discovered while using i40vf (which was deprecated and replaced by iavf). Upon inspecting the code, this problem would also be hit in iavf, if the <span style="color: rgb(0, 0, 0); font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, "system-ui", Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important;" class="ContentPasted0">VIRTCHNL_OP_DEL_ETH_ADDR
and <span style="color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); display: inline !important;" class="ContentPasted1">VIRTCHNL_OP_ADD_ETH_ADDR are not supported.</span></span></div>
<div class="PlainText elementToProof"><span style="color: rgb(0, 0, 0); font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, "system-ui", Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important;" class="ContentPasted0"><span style="color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); display: inline !important;" class="ContentPasted1"><br>
</span></span></div>
<div class="PlainText elementToProof">> The patch aims to rectify that delay.<br>
> In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was<br>
> deleted. Hence adding this in iavf_vchnl.c.<br>
><br>
> Cc: stable@dpdk.org<br>
><br>
> Signed-off-by: Vipin P R <vipinp@vmware.com><br>
> ---<br>
> drivers/net/iavf/iavf_vchnl.c | 8 ++++++++<br>
> 1 file changed, 8 insertions(+)<br>
><br>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index<br>
> f92daf9..e2f65f5 100644<br>
> --- a/drivers/net/iavf/iavf_vchnl.c<br>
> +++ b/drivers/net/iavf/iavf_vchnl.c<br>
> @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter,<br>
> struct iavf_cmd_info *args,<br>
> }<br>
> _clear_cmd(vf);<br>
> break;<br>
> +<br>
> + case VIRTCHNL_OP_ADD_ETH_ADDR:<br>
> + case VIRTCHNL_OP_DEL_ETH_ADDR:<br>
> + PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR<br>
> unsupported");<br>
> + err = 0;<br>
> + _clear_cmd(vf);<br>
> + break;<br>
> +<br>
> default:<br>
> /* For other virtchnl ops in running time,<br>
> * wait for the cmd done flag.<br>
> --<br>
> 2.7.4<br>
<br>
<br>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.<br>
</div>
</span></font></div>
</body>
</html>