<div dir="ltr">Hello Akhil and Gowrishankar,<div><br></div><div>We saw the same issue with running the fips sample app under CI testing here at the UNH Community Lab: <a href="http://mails.dpdk.org/archives/test-report/2023-February/350635.html" target="_blank">http://mails.dpdk.org/archives/test-report/2023-February/350635.html</a>. We reported a warn because it failed on the compilation stage (as opposed to a failure of the actual sample app run).<div><br></div><div>On the other hand, we are excited to see this patch again with the compilation part resolved. I sent an email to the dev mailing list a few weeks ago for our fips sample app CI testing regarding where we could and could not provide test vector coverage, and it appears this patch series may resolve our ciphertext issue with AES-GCM test vector and more issues with the sample app. So - looking forward to seeing a patch like this being merged when stable! </div><div><br></div><div>Best,</div><div>Patrick Robb</div><div><br></div><div><br></div><div><br><br><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 28, 2023 at 2:39 AM Akhil Goyal <<a href="mailto:gakhil@marvell.com" target="_blank">gakhil@marvell.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Gowrishankar,<br> > ><br> > > > Subject: [v1, 00/10] fips_validation application improvements<br> > > ><br> > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors<br> > > > and fixes existing algorithms to support NIST test vectors.<br> > > ><br> > > > Gowrishankar Muthukrishnan (10):<br> > > > examples/fips_validation: fix MCT output for SHA<br> > > > examples/fips_validation: add SHA3 validation<br> > > > examples/fips_validation: fix integer parse in test case<br> > > > examples/fips_validation: add SHAKE validation<br> > > > examples/fips_validation: add CCM JSON validation<br> > > > examples/fips_validation: add ECDSA keygen support<br> > > > examples/fips_validation: add SHA3 algorithms in ECDSA test<br> > > > examples/fips_validation: fix AES GCM validation tests<br> > > > examples/fips_validation: fix AES XTS to read seq number<br> > > > examples/fips_validation: add extra space in JSON buffer<br> > > ><br> > > > doc/guides/sample_app_ug/fips_validation.rst | 7 +-<br> > > > examples/fips_validation/fips_validation.c | 31 ++-<br> > > > examples/fips_validation/fips_validation.h | 10 +-<br> > > > .../fips_validation/fips_validation_ccm.c | 132 ++++++++++++<br> > > > .../fips_validation/fips_validation_ecdsa.c | 56 +++++<br> > > > .../fips_validation/fips_validation_gcm.c | 12 +-<br> > > > .../fips_validation/fips_validation_hmac.c | 8 +<br> > > > .../fips_validation/fips_validation_sha.c | 91 ++++++--<br> > > > .../fips_validation/fips_validation_xts.c | 13 +-<br> > > > examples/fips_validation/main.c | 196 +++++++++++++-----<br> > > > 10 files changed, 467 insertions(+), 89 deletions(-)<br> > > ><br> > > > --<br> > > > 2.25.1<br> > ><br> > > Series-acked-by: Brian Dooley <<a href="mailto:brian.dooley@intel.com" target="_blank">brian.dooley@intel.com</a>><br> > <br> > Series Applied to dpdk-next-crypto<br> The series is showing compilation issues, please fix it. The series is removed from the tree.<br> <br> <br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="font-size:13.3333px;white-space:pre-wrap">Patrick Robb</span></font></p><p style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical Service Manager</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">UNH InterOperability Laboratory</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">21 Madbury Rd, Suite 100, Durham, NH 03824</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(17,85,204);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://www.iol.unh.edu/" style="color:rgb(17,85,204)" target="_blank">www.iol.unh.edu</a></span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><br></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(51,51,51);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><img src="https://lh4.googleusercontent.com/7sTY8VswXadak_YT0J13osh5ockNVRX2BuYaRsKoTTpkpilBokA0WlocYHLB4q7XUgXNHka6-ns47S8R_am0sOt7MYQQ1ILQ3S-P5aezsrjp3-IsJMmMrErHWmTARNgZhpAx06n2" width="150" height="37" style="border: none;"></span></p></div></div>