<div dir="ltr">Sorry for the confusion. I was talking about the same patch (titled net/gve: update copyright holders); however, I am not able to find it on patchwork.<div> </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 12, 2023 at 9:03 AM Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a> > <mailto:<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a>>> wrote: > > > > > -----Original Message----- > > From: Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a> > <mailto:<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>>> > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng <<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a> > <mailto:<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a>>>; Richardson, Bruce > > <<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a> <mailto:<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a>>> > > Cc: <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a> <mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; Zhang, Qi Z > <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a> <mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>>; Rushil Gupta > > <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a> <mailto:<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>>> > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > >> -----Original Message----- > > >> From: Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a> > <mailto:<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>>> > > >> Sent: Wednesday, April 12, 2023 16:50 > > >> To: Guo, Junfeng <<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a> > <mailto:<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a>>>; Richardson, Bruce > > >> <<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a> <mailto:<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a>>> > > >> Cc: <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a> <mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; Zhang, Qi Z > <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a> <mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>>; Rushil Gupta > > >> <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a> <mailto:<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>>> > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > >> > > >> Hi Junfeng, message moved down. > > >> > > >>> > > >>>> -----Original Message----- > > >>>> From: Rushil Gupta <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a> > <mailto:<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>>> > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > >>>> To: Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a> > <mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>>; <a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a> > <mailto:<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>> > > >>>> Cc: Richardson, Bruce <<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a> > <mailto:<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a>>>; > > <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a> <mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; > > >>>> Rushil Gupta <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a> > <mailto:<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>>>; Guo, Junfeng > > >>>> <<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a> <mailto:<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a>>> > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > >>>> > > >>>> Update gve base code to support DQO. > > >>>> > > >>>> This patch is based on this: > > >>>> > > <a href="https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*" rel="noreferrer" target="_blank">https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*</a> > <<a href="https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*" rel="noreferrer" target="_blank">https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*</a>> > > >>>> > > >>>> Signed-off-by: Rushil Gupta <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a> > <mailto:<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>>> > > >>>> Signed-off-by: Junfeng Guo <<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a> > <mailto:<a href="mailto:junfeng.guo@intel.com" target="_blank">junfeng.guo@intel.com</a>>> > > >>> Hi Ferruh & Bruce, > > >>> > > >>> This patch contains few lines change for the MIT licensed gve base > > code. > > >>> Note that there is no new files added, just some minor code > update. > > >>> > > >>> Do we need to ask for special approval from the Tech Board for > this? > > >>> Please help give some advice and also help review this patch. > Thanks! > > >>> > > >> > > >> Once the MIT license exception is in place, as far as I know no > more > > >> approval is required per change. > > > > > > Got it, thanks the comment! > > > > > > Then we may also need your help to review, as well as the coming > patch > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > >> > > >>> BTW, Google will also help replace all the base code under MIT > > license > > >>> with the ones under BSD-3 license soon, which would make things > > more > > >>> easier. > > >>> > > >> > > >> Is this different from base code under DPDK is changing license > [1] ? > > >> > > >> > > >> [1] > > >> > > > <a href="https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar" rel="noreferrer" target="_blank">https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar</a> <<a href="https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar" rel="noreferrer" target="_blank">https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar</a>> > > >> chive=both > > >> > > > > > > The patch set of the above link only contains the processing of > replace > > the > > > MIT licensed base code with the BSD-3 licensed base code. After some > > > discussion, we think Google is in the right place to do that > work. And > > they > > > are working on that now. > > > > > > > Is the Google GVE driver [2] in the process of changing license > from MIT > > to BSD-3? > > > > > > [2] > > <a href="https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-" rel="noreferrer" target="_blank">https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-</a> > <<a href="https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-" rel="noreferrer" target="_blank">https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-</a>> > > linux/tree/v1.3.0/google/gve > > > > I'm not sure, I don't know much about Google's plans. > Maybe they could provide some info here. Thanks! > > @Rushil Gupta > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > > contains > > > only the code part, following previous license statements, > without any > > > license change. > > > > > > This patch is separated and sent by Google, to ensure there is > no license > > > violation. > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > > about BSD-3 licensed files, and that patch set will be sent out > soon. > > > > > > Thanks! > > I have got the green light internally to switch to BSD-3 license for > code under base directory. If it is ok with the tech board, I can send a > patch right away with all of the base files changed to BSD-3 which can > be merged after this patch. Please let me know what you think. > We are also about to upstream driver > code: <a href="https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd" rel="noreferrer" target="_blank">https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd</a> <<a href="https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd" rel="noreferrer" target="_blank">https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd</a>> to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo. +techboard There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send? Or overall I am trying to understand what is this new development on top of existing patch. </blockquote></div>