<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=big5"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Please reply only in plain text format.<o:p></o:p> <o:p> </o:p> All the values are added in the array but are jumbled up.<o:p></o:p> But still it will point to correct position in the array as we are using enum value.<o:p></o:p> Eg. RTE_CRYPTO_CIPHER_NULL = 1,<o:p></o:p> And in the array it is there as highlighted below.<o:p></o:p> Hence there is no hole present in the array.<o:p></o:p> <o:p> </o:p> <o:p> </o:p> static const char *<o:p></o:p> crypto_cipher_algorithm_strings[] = {<o:p></o:p> [RTE_CRYPTO_CIPHER_3DES_CBC] = "3des-cbc",<o:p></o:p> [RTE_CRYPTO_CIPHER_3DES_ECB] = "3des-ecb",<o:p></o:p> [RTE_CRYPTO_CIPHER_3DES_CTR] = "3des-ctr",<o:p></o:p> <o:p> </o:p> [RTE_CRYPTO_CIPHER_AES_CBC] = "aes-cbc",<o:p></o:p> [RTE_CRYPTO_CIPHER_AES_CTR] = "aes-ctr",<o:p></o:p> [RTE_CRYPTO_CIPHER_AES_DOCSISBPI] = "aes-docsisbpi",<o:p></o:p> [RTE_CRYPTO_CIPHER_AES_ECB] = "aes-ecb",<o:p></o:p> [RTE_CRYPTO_CIPHER_AES_F8] = "aes-f8",<o:p></o:p> [RTE_CRYPTO_CIPHER_AES_XTS] = "aes-xts",<o:p></o:p> <o:p> </o:p> [RTE_CRYPTO_CIPHER_ARC4] = "arc4",<o:p></o:p> <o:p> </o:p> [RTE_CRYPTO_CIPHER_DES_CBC] = "des-cbc",<o:p></o:p> [RTE_CRYPTO_CIPHER_DES_DOCSISBPI] = "des-docsisbpi",<o:p></o:p> <o:p> </o:p> [RTE_CRYPTO_CIPHER_NULL] = "null", ---------------------------------------à<o:p></o:p> <o:p> </o:p> [RTE_CRYPTO_CIPHER_KASUMI_F8] = "kasumi-f8",<o:p></o:p> [RTE_CRYPTO_CIPHER_SNOW3G_UEA2] = "snow3g-uea2",<o:p></o:p> [RTE_CRYPTO_CIPHER_ZUC_EEA3] = "zuc-eea3",<o:p></o:p> [RTE_CRYPTO_CIPHER_SM4_ECB] = "sm4-ecb",<o:p></o:p> [RTE_CRYPTO_CIPHER_SM4_CBC] = "sm4-cbc",<o:p></o:p> [RTE_CRYPTO_CIPHER_SM4_CTR] = "sm4-ctr",<o:p></o:p> [RTE_CRYPTO_CIPHER_SM4_CFB] = "sm4-cfb",<o:p></o:p> [RTE_CRYPTO_CIPHER_SM4_OFB] = "sm4-ofb"<o:p></o:p> };<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: liu xixin <liuxixin2020@outlook.com> Sent: Friday, June 9, 2023 1:45 PM To: Akhil Goyal <gakhil@marvell.com>; dev@dpdk.org Subject: �^�`: [EXT] [PATCH v2] cryptodev: avoid algorithm strings null pointers<o:p></o:p> </div> </div> <o:p> </o:p> <div> > -----Original Message-----<o:p></o:p> </div> <div> <div> > From: liu xixin <<a href="mailto:liuxixin2020@outlook.com">liuxixin2020@outlook.com</a>> > Sent: Friday, June 9, 2023 12:31 PM > To: Akhil Goyal <<a href="mailto:gakhil@marvell.com">gakhil@marvell.com</a>>; <a href="mailto:dev@dpdk.org"> dev@dpdk.org</a> > Subject: ��`: [EXT] [PATCH v2] cryptodev: avoid algorithm strings null pointers > > > Subject: [EXT] [PATCH v2] cryptodev: avoid algorithm strings null > > pointers > > > > The crypto algorithm strings identifiers that are Continuous may be > > null, so there is needed to add null judgment. > > When testing with dpdk-test-crypto-perf and passing in the parameter > > --auth-algo sm3-hmac, The program caused a segfault due to a null > > pointer passed in by strcmp. > > Adding this patch can solve the segfault problem. > > I believe this is a fix and you should add fixes tag for this and need to be > backported. > > > > > Signed-off-by: xixin.liu <<a href="mailto:liuxixin2020@outlook.com">liuxixin2020@outlook.com</a>> > > Signoff format is not correct. > Please follow <a href="https://urldefense.proofpoint.com/v2/url?u=https-">https://urldefense.proofpoint.com/v2/url?u=https-</a> > 3A__doc.dpdk.org_guides_contributing_patches.html&d=DwIGoQ&c=nKjWec2b > 6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m > =6mzvm07Go5- > S_2jVk9KRF1mOl0Juay2Sa2WI2XiNgTbg6ZhMcm75GNceSVhe0Doj&s=tvqhxvElc > m_8h3e7YIBym6IAHk6BxUAFx2RKmjJ6Ibw&e= > > > > --- > > lib/cryptodev/rte_cryptodev.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/lib/cryptodev/rte_cryptodev.c > > b/lib/cryptodev/rte_cryptodev.c index a96114b2da..41c23fc596 100644 > > --- a/lib/cryptodev/rte_cryptodev.c > > +++ b/lib/cryptodev/rte_cryptodev.c > > @@ -346,6 +346,8 @@ rte_cryptodev_get_cipher_algo_enum(enum > > rte_crypto_cipher_algorithm *algo_enum, > > int ret = -1; /* Invalid string */ > > > > for (i = 1; i < RTE_DIM(crypto_cipher_algorithm_strings); i++) { > > + if (crypto_cipher_algorithm_strings[i] == NULL) > > + continue; > > crypto_cipher_algorithm_strings is a fixed size array with all non-NULL known > values and the for loop is iterating over it. So, this check does not make sense to > me. > ----> Not every element of the array is defined, eg. it is NULL that the first > element [1], if not check "strcmp(algo_string, > crypto_cipher_algorithm_strings[i]" will fail The loop starts from 1 so 0th element = NULL will not matter.<o:p></o:p> </div> <div> And for all other values it is not null. If something is missing, then it can be added.<o:p></o:p> </div> <div> But this check is not needed.<o:p></o:p> </div> <div> ---> [0] is no need to check �CHowever, the values of all subsequent elements are checked to be null<o:p></o:p> </div> <div> <div> static const char * <o:p></o:p> <div> crypto_cipher_algorithm_strings[] = {<o:p></o:p> </div> <div> [RTE_CRYPTO_CIPHER_3DES_CBC] = "3des-cbc", //this RTE_CRYPTO_CIPHER_3DES_CBC == 2�Aso �i1�jalready is NULL<o:p></o:p> </div> <div> [RTE_CRYPTO_CIPHER_3DES_ECB] = "3des-ecb", // same as RTE_CRYPTO_CIPHER_3DES_ECB == 4 �Aand now �i1�j�i3�jare all NULL<o:p></o:p> </div> <div> [RTE_CRYPTO_CIPHER_3DES_CTR] = "3des-ctr", // and so on<o:p></o:p> </div> <div> ...<o:p></o:p> </div> };<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>