<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</mata><style type="text/css">
* {box-sizing:border-box;}
body {font-family: Calibri;}
</style>
</head>
<body>
<div>
<div id="focus">
<div><br>
<br>
<br>
<br>
<br>
</div>
</div>
</div>
<div></div>
<div id="signature">
<hr style="border-top:dotted 1px">
<br>
Konstantin Ananyev<br>
Mobile: +353-873459988<br>
Email: konstantin.ananyev@huawei.com<br>
<br>
</div>
<div name="AnyOffice-Background-Image" style="border-top:1px solid #B5C4DF;padding:8px; background-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAABBCAYAAAAQTc7lAAAACXBIWXMAAAsTAAALEwEAmpwYAAAABGdBTUEAALGOfPtRkwAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+SX8VGAAAAN0lEQVR42mJ48u7PfyYGBoZ/cOIvKgsb8QeVhZ/4jYX7GwsXpxh+gghTcLoFJ4HmS2wEUlgBBgAjPkNRQlGPfAAAAABJRU5ErkJggg==); background-repeat: repeat-x;">
<div style="word-break:break-all;"><b>From:</b>zhoumin <zhoumin@loongson.cn></div>
<div style="word-break:break-all;"><b>To:</b>Thomas Monjalon <thomas@monjalon.net>;Ruifeng Wang <Ruifeng.Wang@arm.com>;Zhang, Qi Z <qi.z.zhang@intel.com></div>
<div style="word-break:break-all;"><b>Cc:</b>dev <dev@dpdk.org>;mb <mb@smartsharesystems.com>;konstantin.v.ananyev <konstantin.v.ananyev@yandex.ru>;Yang, Qiming <qiming.yang@intel.com>;Wu, Wenjun1 <wenjun1.wu@intel.com>;drc <drc@linux.vnet.ibm.com>;roretzla
<roretzla@linux.microsoft.com>;stable <stable@dpdk.org>;maobibo <maobibo@loongson.cn>;nd <nd@arm.com>;David Marchand <david.marchand@redhat.com>;honnappa.nagarahalli <honnappa.nagarahalli@arm.com>;Tyler Retzlaff <roretzla@microsoft.com>;Konstantin Ananyev
<konstantin.ananyev@huawei.com></div>
<div style="word-break:break-all;"><b>Date:</b>2023-06-13 04:43:12</div>
<div style="word-break:break-all;"><b>Subject:</b>Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions</div>
<div><br>
</div>
</div>
<div name="mail_hist_content"><font><span style="font-size: 10pt; background-color: inherit;">
<div class="PlainText">Hi Thomas,<br>
<br>
On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote:<br>
> 12/06/2023 13:58, zhoumin:<br>
>> On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote:<br>
>>> 15/05/2023 04:10, Zhang, Qi Z:<br>
>>>> From: Ruifeng Wang <<a href="mailto:Ruifeng.Wang@arm.com">Ruifeng.Wang@arm.com</a>><br>
>>>>> From: Min Zhou <<a href="mailto:zhoumin@loongson.cn">zhoumin@loongson.cn</a>><br>
>>>>>> ---<br>
>>>>>> v3:<br>
>>>>>> - Use rte_smp_rmb() as the proper memory barrier instead of rte_rmb()<br>
>>>>>> ---<br>
>>>>>> v2:<br>
>>>>>> - Make the calling of rte_rmb() for all platforms<br>
>>>>>> ---<br>
>>> [...]<br>
>>>>> Reviewed-by: Ruifeng Wang <<a href="mailto:ruifeng.wang@arm.com">ruifeng.wang@arm.com</a>><br>
>>>> Applied to dpdk-next-net-intel.<br>
>>>><br>
>>>> Thanks<br>
>>>> Qi<br>
>>>><br>
>>> Why ignoring checkpatch?<br>
>>> It is saying:<br>
>>> "<br>
>>> Warning in drivers/net/ixgbe/ixgbe_rxtx.c:<br>
>>> Using rte_smp_[r/w]mb<br>
>>> "<br>
>><br>
>> I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code?<br>
> No we should avoid.<br>
> It has been decided to slowly replace such barriers.<br>
> By the way, I think it is not enough documented.<br>
> You can find an explanation in doc/guides/rel_notes/deprecation.rst<br>
Thank your for providing the reference documents. I have read this file. <br>
The explanation is clear and I get it.<br>
> I think we should also add some notes to<br>
> lib/eal/include/generic/rte_atomic.h<br>
Yes, I do think so. The notes added at the definitions of <br>
rte_smp_[r/w]mb are better.<br>
> Tyler, Honnappa, Ruifeng, Konstantin, what do you think?<br>
></div>
<div class="PlainText">Yes, extra notes sounds like a reasonable thing to me.<br>
<br>
<br>
</div>
</span></font><br>
</div>
</body>
</html>