<div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">Acked-by: Jeremy Spweock <<a href="mailto:jspweock@iol.unh.edu" target="_blank">jspweock@iol.unh.edu</a>></div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 16, 2023 at 6:32 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, May 16, 2023 at 12:16 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote: > > Poetry changed the syntax of dev dependencies section in version > 1.2.0. Remove the scripts section that did nothing. > Update Pylama linters: > * pep8 is the same as pycodestyle > * pylint is missing dependencies and thus not executed. It reports a > number of warnings and may be introduced in a future patch. > * mypy doesn't work properly with Pylama. Pylama executes linting > file-by-file and mypy works on all files at once. > > Mypy has thus been moved outside Pylama and is executed separately. > Added Mypy configuration that allows fine-grained specification of > ignored issues. > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > --- > devtools/dts-check-format.sh | 21 ++- > doc/guides/tools/dts.rst | 1 + > dts/poetry.lock | 304 +++++++++++++++++++++++++++-------- > dts/pyproject.toml | 26 ++- > 4 files changed, 276 insertions(+), 76 deletions(-) > > > diff --git a/dts/poetry.lock b/dts/poetry.lock > index 0b2a007d4d..64d6c18f35 100644 > --- a/dts/poetry.lock > +++ b/dts/poetry.lock > @@ -1,24 +1,45 @@ > +# This file is automatically @generated by Poetry and should not be changed by hand. > + Let's continue the discussion about the generated file we started here: <a href="http://patches.dpdk.org/project/dpdk/patch/20230403114608.1423020-1-juraj.linkes@pantheon.tech/" rel="noreferrer" target="_blank">http://patches.dpdk.org/project/dpdk/patch/20230403114608.1423020-1-juraj.linkes@pantheon.tech/</a> <snip> > [[package]] > name = "mypy" > @@ -116,6 +165,31 @@ description = "Optional static typing for Python" > category = "dev" > optional = false > python-versions = ">=3.6" > +files = [ > + {file = "mypy-0.961-cp310-cp310-macosx_10_9_universal2.whl", hash = "sha256:697540876638ce349b01b6786bc6094ccdaba88af446a9abb967293ce6eaa2b0"}, > + {file = "mypy-0.961-cp310-cp310-macosx_10_9_x86_64.whl", hash = "sha256:b117650592e1782819829605a193360a08aa99f1fc23d1d71e1a75a142dc7e15"}, > + {file = "mypy-0.961-cp310-cp310-macosx_11_0_arm64.whl", hash = "sha256:bdd5ca340beffb8c44cb9dc26697628d1b88c6bddf5c2f6eb308c46f269bb6f3"}, > + {file = "mypy-0.961-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:3e09f1f983a71d0672bbc97ae33ee3709d10c779beb613febc36805a6e28bb4e"}, > + {file = "mypy-0.961-cp310-cp310-win_amd64.whl", hash = "sha256:e999229b9f3198c0c880d5e269f9f8129c8862451ce53a011326cad38b9ccd24"}, > + {file = "mypy-0.961-cp36-cp36m-macosx_10_9_x86_64.whl", hash = "sha256:b24be97351084b11582fef18d79004b3e4db572219deee0212078f7cf6352723"}, > + {file = "mypy-0.961-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:f4a21d01fc0ba4e31d82f0fff195682e29f9401a8bdb7173891070eb260aeb3b"}, > + {file = "mypy-0.961-cp36-cp36m-win_amd64.whl", hash = "sha256:439c726a3b3da7ca84a0199a8ab444cd8896d95012c4a6c4a0d808e3147abf5d"}, > + {file = "mypy-0.961-cp37-cp37m-macosx_10_9_x86_64.whl", hash = "sha256:5a0b53747f713f490affdceef835d8f0cb7285187a6a44c33821b6d1f46ed813"}, > + {file = "mypy-0.961-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:0e9f70df36405c25cc530a86eeda1e0867863d9471fe76d1273c783df3d35c2e"}, > + {file = "mypy-0.961-cp37-cp37m-win_amd64.whl", hash = "sha256:b88f784e9e35dcaa075519096dc947a388319cb86811b6af621e3523980f1c8a"}, > + {file = "mypy-0.961-cp38-cp38-macosx_10_9_universal2.whl", hash = "sha256:d5aaf1edaa7692490f72bdb9fbd941fbf2e201713523bdb3f4038be0af8846c6"}, > + {file = "mypy-0.961-cp38-cp38-macosx_10_9_x86_64.whl", hash = "sha256:9f5f5a74085d9a81a1f9c78081d60a0040c3efb3f28e5c9912b900adf59a16e6"}, > + {file = "mypy-0.961-cp38-cp38-macosx_11_0_arm64.whl", hash = "sha256:f4b794db44168a4fc886e3450201365c9526a522c46ba089b55e1f11c163750d"}, > + {file = "mypy-0.961-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:64759a273d590040a592e0f4186539858c948302c653c2eac840c7a3cd29e51b"}, > + {file = "mypy-0.961-cp38-cp38-win_amd64.whl", hash = "sha256:63e85a03770ebf403291ec50097954cc5caf2a9205c888ce3a61bd3f82e17569"}, > + {file = "mypy-0.961-cp39-cp39-macosx_10_9_universal2.whl", hash = "sha256:5f1332964963d4832a94bebc10f13d3279be3ce8f6c64da563d6ee6e2eeda932"}, > + {file = "mypy-0.961-cp39-cp39-macosx_10_9_x86_64.whl", hash = "sha256:006be38474216b833eca29ff6b73e143386f352e10e9c2fbe76aa8549e5554f5"}, > + {file = "mypy-0.961-cp39-cp39-macosx_11_0_arm64.whl", hash = "sha256:9940e6916ed9371809b35b2154baf1f684acba935cd09928952310fbddaba648"}, > + {file = "mypy-0.961-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:a5ea0875a049de1b63b972456542f04643daf320d27dc592d7c3d9cd5d9bf950"}, > + {file = "mypy-0.961-cp39-cp39-win_amd64.whl", hash = "sha256:1ece702f29270ec6af25db8cf6185c04c02311c6bb21a69f423d40e527b75c56"}, > + {file = "mypy-0.961-py3-none-any.whl", hash = "sha256:03c6cc893e7563e7b2949b969e63f02c000b32502a1b4d1314cabe391aa87d66"}, > + {file = "mypy-0.961.tar.gz", hash = "sha256:f730d56cb924d371c26b8eaddeea3cc07d78ff51c521c6d04899ac6904b75492"}, > +] The contentious point was the non-linux files among the lists of files in some packages. I think leaving these in doesn't result in any extra work in terms of review or maintenance. There's no reason to review this file, as it's effectively automatically managed by Poetry and the only maintenance needed is to update it when updating/adding dependencies. In addition, no one will (or should) ever look into this file, it's not meant to be consumed by users. Also, DTS is designed to allow support for different OS's (if anyone wishes to implement it), so leaving it in makes sense in this way. </blockquote></div>