<div dir="ltr"><div>HI,</div><div>not sure to understand how it is possible.</div><div>If build
OPENSSL_VERSION_NUMBER <
0x10100000L, linker should link binary with libcrypto.so.1.0.0. <br></div><div>libcrypto.so.1.1 if build for 0x10100000L and
libcrypto.so.3 for 0x30000000L <br></div><div>loader should not allow to link with a library different from the one used at build time, no?</div><div><br></div><div>didier<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jun 25, 2023 at 9:22 PM Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">18/04/2023 16:56, Didier Pallard:<br>
> This workaround was needed before version 1.0.1f. Do not build it for<br>
> versions >= 1.1.<br>
> <br>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")<br>
> Signed-off-by: Didier Pallard <<a href="mailto:didier.pallard@6wind.com" target="_blank">didier.pallard@6wind.com</a>><br>
> Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a><br>
[...]<br>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L<br>
> /* Workaround open ssl bug in version less then 1.0.1f */<br>
> if (EVP_EncryptUpdate(ctx, empty, &unused, empty, 0) <= 0)<br>
> goto process_auth_encryption_gcm_err;<br>
> +#endif<br>
<br>
What happens if we build with OpenSSL 1.1 and run with OpenSSL 1.0?<br>
Can we have a runtime check?<br>
Or is it better doing the workaround always as before?<br>
<br>
<br>
</blockquote></div>