<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: "Sitka Text", Cochin, serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0">
Acked-by: Kai Ji <<a href="mailto:kai.ji@intel.com" class="ContentPasted0" data-loopstyle="linkonly">kai.ji@intel.com</a>><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Power, Ciara <ciara.power@intel.com><br>
<b>Sent:</b> 05 July 2023 14:23<br>
<b>To:</b> dev@dpdk.org <dev@dpdk.org><br>
<b>Cc:</b> Ji, Kai <kai.ji@intel.com>; O'Donovan, Saoirse <saoirse.odonovan@intel.com>; Power, Ciara <ciara.power@intel.com><br>
<b>Subject:</b> [PATCH] crypto/qat: fix legacy sm4 ecb capability</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Following the deprecation of insecure algorithms in QAT,<br>
SM4-ECB should be included as legacy, to be disabled by default.<br>
<br>
Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")<br>
<br>
Signed-off-by: Ciara Power <ciara.power@intel.com><br>
---<br>
drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c<br>
index bc71665a50..d25e1b2f3a 100644<br>
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c<br>
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c<br>
@@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_legacy_caps_gen3[] = {<br>
QAT_SYM_PLAIN_AUTH_CAP(SHA3_224,<br>
CAP_SET(block_size, 144),<br>
CAP_RNG(digest_size, 28, 28, 0)),<br>
+ QAT_SYM_CIPHER_CAP(SM4_ECB,<br>
+ CAP_SET(block_size, 16),<br>
+ CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))<br>
};<br>
<br>
static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {<br>
@@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {<br>
CAP_RNG(key_size, 32, 32, 0),<br>
CAP_RNG(digest_size, 16, 16, 0),<br>
CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)),<br>
- QAT_SYM_CIPHER_CAP(SM4_ECB,<br>
- CAP_SET(block_size, 16),<br>
- CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),<br>
QAT_SYM_CIPHER_CAP(SM4_CBC,<br>
CAP_SET(block_size, 16),<br>
CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</body>
</html>