<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.pl-c1
{mso-style-name:pl-c1;}
span.pl-en
{mso-style-name:pl-en;}
span.pl-k
{mso-style-name:pl-k;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi, Yan<o:p></o:p></p>
<p class="MsoNormal"><br>
Sorry, I do not follow the letter?<br>
Are you proposing the patch for bonding PMD?<o:p></o:p></p>
<p class="MsoNormal">If so, could you, please send your patch in plain text, according to ML rules?<br>
<br>
It is application responsibility to start bonding virtual device (and it will start its slaves)<o:p></o:p></p>
<p class="MsoNormal">before flow creation.<o:p></o:p></p>
<p class="MsoNormal"><br>
With best regards,<br>
Slava<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="mso-fareast-language:ZH-CN">From:</span></b><span style="mso-fareast-language:ZH-CN"> compile_success <980965867@qq.com>
<br>
<b>Sent:</b> Tuesday, June 20, 2023 6:26 PM<br>
<b>To:</b> users <users@dpdk.org>; dev <dev@dpdk.org>; Matan Azrad <matan@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com><br>
<b>Subject:</b> net/mlx:mlx5 mlx_flow_create failed when set bond_mode_8023<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">When I create bond4 with ConnectX-4 , mlx_flow_create return error;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">When bond_port is opened, slave_port will be closed to sync bond_port config
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"MS Gothic"">（</span>bond_ethdev_start -> slave_configure-><span class="pl-c1">rte_eth_dev_stop</span><span style="font-family:"MS Gothic"">）</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1716">
<p class="MsoNormal"><span class="pl-en"><i><span style="font-size:10.0pt">slave_configure</span></i></span><i><span style="font-size:10.0pt">(<span class="pl-k">struct</span> rte_eth_dev *bonded_eth_dev,</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt;display:table-cell;background-color:rgba(0, 0, 0, 0)" id="LC1717">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">struct rte_eth_dev *slave_eth_dev)</span></i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black"><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1718">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">{</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1719">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">uint16_t nb_rx_queues;</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt;display:table-cell;background-color:rgba(0, 0, 0, 0)" id="LC1720">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">uint16_t nb_tx_queues;</span></i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black"><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1721"></td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1722">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">int errval;</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1723"></td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1724">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1725"></td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1726">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">/* Stop slave */</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1727">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">errval = rte_eth_dev_stop(slave_eth_dev->data->port_id);</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1728">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">if (errval != 0)</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt;display:table-cell;background-color:rgba(0, 0, 0, 0)" id="LC1729">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">RTE_BOND_LOG(ERR, "rte_eth_dev_stop: port %u, err (%d)",</span></i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black"><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1730">
<p class="MsoNormal"><i><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:black">slave_eth_dev->data->port_id, errval);</span></i><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt" id="LC1715">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
However, If the device is not started yetm it is not allowed to created a flow from application.<br>
<span style="font-family:"MS Gothic"">（</span>slave_configure -> <span class="pl-c1">
bond_ethdev_8023ad_flow_set -> rte_flow_create -> mlx5_flow_create</span><span style="font-family:"MS Gothic"">）</span><br>
<br>
I want to add <span class="pl-c1">rte_eth_dev_start before bond_ethdev_8023ad_flow_set. This can solve my problem.</span><br>
<img width="634" height="732" style="width:6.6041in;height:7.625in" id="img_insert_168727388848702527905893169221" src="cid:image001.png@01D9B4CB.A5D91B50"><o:p></o:p></p>
</td>
</tr>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
<div class="MsoNormal" style="margin-bottom:7.5pt">
<hr size="0" width="50" style="width:37.5pt" align="left">
</div>
</div>
</div>
</div>
</body>
</html>